mirror of
				https://gitlab.freedesktop.org/pipewire/pipewire.git
				synced 2025-11-03 09:01:54 -05:00 
			
		
		
		
	media-session: don't move nodes to same link-group
Refuse to move a node to a new target when they belong to the same link-group to avoid loops. Fixes #1376
This commit is contained in:
		
							parent
							
								
									6e44c081b0
								
							
						
					
					
						commit
						cb3543e9b4
					
				
					 1 changed files with 6 additions and 1 deletions
				
			
		| 
						 | 
					@ -1052,7 +1052,12 @@ static int handle_move(struct impl *impl, struct node *src_node, struct node *ds
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if ((str = spa_dict_lookup(info->props, PW_KEY_NODE_DONT_RECONNECT)) != NULL &&
 | 
						if ((str = spa_dict_lookup(info->props, PW_KEY_NODE_DONT_RECONNECT)) != NULL &&
 | 
				
			||||||
		    pw_properties_parse_bool(str)) {
 | 
							    pw_properties_parse_bool(str)) {
 | 
				
			||||||
		pw_log_warn("can't reconnect node %d to %d", src_node->id,
 | 
							pw_log_warn("can't reconnect node %d to %d: dont-reconnect flag set",
 | 
				
			||||||
 | 
									src_node->id, dst_node->id);
 | 
				
			||||||
 | 
							return -EPERM;
 | 
				
			||||||
 | 
						}
 | 
				
			||||||
 | 
						if (!can_link(impl, src_node, dst_node)) {
 | 
				
			||||||
 | 
							pw_log_debug("can't link node %d to %d: same link-group", src_node->id,
 | 
				
			||||||
				dst_node->id);
 | 
									dst_node->id);
 | 
				
			||||||
		return -EPERM;
 | 
							return -EPERM;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue