mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

clarify deprecated use of NODE_TARGET

Browse source
This commit is contained in:
Wim Taymans 2023-01-10 17:21:02 +01:00
parent c3032c70b6
commit cab3e3c1ce
4 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/gst/gstpipewiresink.c
View file

@ -584,6 +584,8 @@ gst_pipewire_sink_setcaps (GstBaseSink * bsink, GstCaps * caps)
if (pwsink->target_object) {
struct spa_dict_item items[2] = {
SPA_DICT_ITEM_INIT(PW_KEY_TARGET_OBJECT, pwsink->target_object),
/* XXX deprecated but the portal and some example apps only
* provide the object id */
SPA_DICT_ITEM_INIT(PW_KEY_NODE_TARGET, NULL),
};
struct spa_dict dict = SPA_DICT_INIT_ARRAY(items);

2
src/gst/gstpipewiresrc.c
View file

@ -844,6 +844,8 @@ gst_pipewire_src_negotiate (GstBaseSrc * basesrc)
if (pwsrc->target_object) {
struct spa_dict_item items[2] = {
SPA_DICT_ITEM_INIT(PW_KEY_TARGET_OBJECT, pwsrc->target_object),
/* XXX deprecated but the portal and some example apps only
* provide the object id */
SPA_DICT_ITEM_INIT(PW_KEY_NODE_TARGET, NULL),
};
struct spa_dict dict = SPA_DICT_INIT_ARRAY(items);

1
src/modules/module-client-node/v0/client-node.c
View file

@ -1332,6 +1332,7 @@ static void convert_properties(struct pw_properties *properties)
const char *from, *to;
} props[] = {
{ "pipewire.autoconnect", PW_KEY_NODE_AUTOCONNECT, },
/* XXX deprecated */
{ "pipewire.target.node", PW_KEY_NODE_TARGET, }
};

2
src/pipewire/stream.c
View file

@ -1892,7 +1892,7 @@ pw_stream_connect(struct pw_stream *stream,
stream_set_state(stream, PW_STREAM_STATE_CONNECTING, NULL);
if (target_id != PW_ID_ANY)
/* this is deprecated but still used by the portal and its apps */
/* XXX this is deprecated but still used by the portal and its apps */
pw_properties_setf(stream->properties, PW_KEY_NODE_TARGET, "%d", target_id);
else if ((str = getenv("PIPEWIRE_NODE")) != NULL)
pw_properties_set(stream->properties, PW_KEY_TARGET_OBJECT, str);