mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-01 22:58:50 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluez5: endpoint can be used only by one device at a time

Browse source 
AVDTP (v1.3 Sec 5.3) has a limitation that a local SEP (on the same
adapter) can be connected to at most one remote SEP. Trying to do have
it connected to multiple remotes either fails or causes misbehavior
later on.

Skip SetConfigure the same local endpoint for multiple remote ones in
codec switch. BlueZ observes this restriction in SelectConfiguration,
so also it won't try to do invalid configurations.

In BlueZ 5.64, the SetConfiguration calls succeed, but subsequent
transport acquires will fail. (Likely already the SetConfiguration DBus
call should fail.)

This all has the consequence, with the current approach to the
codec=endpoint correspondence, that if multiple devices are connected to
the same adapter, they currently have to use different codecs.
This commit is contained in:
Pauli Virtanen 2022-05-26 12:44:07 +03:00 • committed by Wim Taymans
parent 85ca67b927
commit ca18b8b733
2 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

17
spa/plugins/bluez5/bluez5-dbus.c
View file

@ -1867,6 +1867,7 @@ void spa_bt_transport_free(struct spa_bt_transport *transport)
if (device && device->connected_profiles != prev_connected)
spa_bt_device_emit_profiles_changed(device, device->profiles, prev_connected);
free(transport->endpoint_path);
free(transport->path);
free(transport);
}
@ -2530,6 +2531,7 @@ static void a2dp_codec_switch_next(struct spa_bt_a2dp_codec_switch *sw)
static bool a2dp_codec_switch_process_current(struct spa_bt_a2dp_codec_switch *sw)
{
struct spa_bt_remote_endpoint *ep;
struct spa_bt_transport *t;
const struct a2dp_codec *codec;
uint8_t config[A2DP_MAX_CAPS_SIZE];
char *local_endpoint_base;
@ -2584,6 +2586,19 @@ static bool a2dp_codec_switch_process_current(struct spa_bt_a2dp_codec_switch *s
goto next;
}
/* Each endpoint can be used by only one device at a time (on each adapter) */
spa_list_for_each(t, &sw->device->monitor->transport_list, link) {
if (t->device == sw->device)
continue;
if (t->device->adapter != sw->device->adapter)
continue;
if (spa_streq(t->endpoint_path, local_endpoint)) {
spa_log_debug(sw->device->monitor->log, "a2dp codec switch %p: endpoint %s in use, try next",
sw, local_endpoint);
goto next;
}
}
res = codec->select_config(codec, 0, ep->capabilities, ep->capabilities_len,
&sw->device->monitor->default_audio_info,
sw->device->settings, config);
@ -3031,6 +3046,8 @@ static DBusHandlerResult endpoint_set_configuration(DBusConnection *conn,
transport->volumes[i].hw_volume_max = SPA_BT_VOLUME_A2DP_MAX;
}
free(transport->endpoint_path);
transport->endpoint_path = strdup(endpoint);
transport->profile = profile;
transport->a2dp_codec = codec;
transport_update_props(transport, &it[1], NULL);