From c91e9ded7dbeed9ccb48772dade7cb1441e4a167 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 6 May 2026 16:23:08 +0200 Subject: [PATCH] modules: handle more stream setup failures Instead of silently ignoring things. --- src/modules/module-echo-cancel.c | 4 +++- src/modules/module-example-filter.c | 4 +++- src/modules/module-filter-chain.c | 3 ++- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/src/modules/module-echo-cancel.c b/src/modules/module-echo-cancel.c index 390563db2..0c6e25535 100644 --- a/src/modules/module-echo-cancel.c +++ b/src/modules/module-echo-cancel.c @@ -1616,6 +1616,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) } pw_properties_free(props); + props = NULL; pw_proxy_add_listener((struct pw_proxy*)impl->core, &impl->core_proxy_listener, @@ -1624,7 +1625,8 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) &impl->core_listener, &core_events, impl); - setup_streams(impl); + if ((res = setup_streams(impl)) < 0) + goto error; pw_impl_module_add_listener(module, &impl->module_listener, &module_events, impl); diff --git a/src/modules/module-example-filter.c b/src/modules/module-example-filter.c index 8c3d8bde5..89ae782a7 100644 --- a/src/modules/module-example-filter.c +++ b/src/modules/module-example-filter.c @@ -623,6 +623,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) } pw_properties_free(props); + props = NULL; pw_proxy_add_listener((struct pw_proxy*)impl->core, &impl->core_proxy_listener, @@ -631,7 +632,8 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) &impl->core_listener, &core_events, impl); - setup_streams(impl); + if ((res = setup_streams(impl)) < 0) + goto error; pw_impl_module_add_listener(module, &impl->module_listener, &module_events, impl); diff --git a/src/modules/module-filter-chain.c b/src/modules/module-filter-chain.c index d89a4bc98..acfc85ed0 100644 --- a/src/modules/module-filter-chain.c +++ b/src/modules/module-filter-chain.c @@ -2084,7 +2084,8 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) &impl->core_listener, &core_events, impl); - setup_streams(impl); + if ((res = setup_streams(impl)) < 0) + goto error; pw_impl_module_add_listener(module, &impl->module_listener, &module_events, impl);