mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-rtp: use sess.latency.msec also for sender

Browse source 
Use the sess.latency.msec also for the sender and use it to control the
NODE_LATENCY. Make it a float to be in line with the other time values.
Set is to a default of ptime, which was what it used to be.

This makes it possible to set the ptime to a smaller value than the
sess.latency.msec so that we send out multiple packets per quantum.
This will result in some bursty output for now but with a timer that can
be improved later.

Update the docs a little, mention the new rtp.ptime and rtp.frametime.
This commit is contained in:
Wim Taymans 2024-01-25 15:42:16 +01:00
parent ec825086f1
commit c37f9f9cf0
4 changed files with 24 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/modules/module-rtp/stream.c
View file

@ -284,7 +284,7 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
float min_ptime, max_ptime;
const struct spa_pod *params[1];
enum pw_stream_flags flags;
int latency_msec;
float latency_msec;
int res;
impl = calloc(1, sizeof(*impl));
@ -450,16 +450,23 @@ struct rtp_stream *rtp_stream_new(struct pw_core *core,
pw_properties_setf(props, "rtp.framecount", "%u", impl->psamples);
}
}
latency_msec = pw_properties_get_uint32(props,
"sess.latency.msec", DEFAULT_SESS_LATENCY);
/* For senders, the default latency is ptime and for a receiver it is
* DEFAULT_SESS_LATENCY. Setting the sess.latency.msec for a sender to
* something smaller/bigger will influence the quantum and the amount
* of packets we send in one cycle */
str = pw_properties_get(props, "sess.latency.msec");
if (!spa_atof(str, &latency_msec)) {
latency_msec = direction == PW_DIRECTION_INPUT ?
samples_to_msec(impl, impl->psamples) :
DEFAULT_SESS_LATENCY;
}
impl->target_buffer = msec_to_samples(impl, latency_msec);
impl->max_error = msec_to_samples(impl, ERROR_MSEC);
pw_properties_setf(props, PW_KEY_NODE_RATE, "1/%d", impl->rate);
if (direction == PW_DIRECTION_INPUT) {
// TODO: make sess.latency.msec work for sender streams
pw_properties_setf(props, PW_KEY_NODE_LATENCY, "%d/%d",
impl->psamples, impl->rate);
impl->target_buffer, impl->rate);
} else {
pw_properties_setf(props, PW_KEY_NODE_LATENCY, "%d/%d",
impl->target_buffer / 2, impl->rate);