mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

spa: acp: indicate ALSA UCM profile errors in UIs

Browse source 
Add "[ALSA UCM error]" to the end of card description, to indicate
something is wrong.
This commit is contained in:
Pauli Virtanen 2025-03-13 19:23:32 +02:00 • committed by Wim Taymans
parent 4338189f76
commit bd3a8b594f
3 changed files with 29 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

23
spa/plugins/alsa/acp/acp.c
View file

@ -498,6 +498,7 @@ static void add_profiles(pa_card *impl)
int n_profiles, n_ports, n_devices;
uint32_t idx;
const char *arr;
bool broken_ucm = false;
n_devices = 0;
pa_dynarray_init(&impl->out.devices, device_free);
@ -541,6 +542,9 @@ static void add_profiles(pa_card *impl)
dev->ports, NULL);
pa_dynarray_append(&ap->out.devices, dev);
if (m->split && m->split->broken)
broken_ucm = true;
}
}
@ -564,6 +568,9 @@ static void add_profiles(pa_card *impl)
dev->ports, NULL);
pa_dynarray_append(&ap->out.devices, dev);
if (m->split && m->split->broken)
broken_ucm = true;
}
}
cp->n_devices = pa_dynarray_size(&ap->out.devices);
@ -571,6 +578,22 @@ static void add_profiles(pa_card *impl)
pa_hashmap_put(impl->profiles, ap->name, cp);
}
/* Add a conspicuous notice if there are errors in the UCM profile */
if (broken_ucm) {
const char *desc;
char *new_desc = NULL;
desc = pa_proplist_gets(impl->proplist, PA_PROP_DEVICE_DESCRIPTION);
if (!desc)
desc = "";
new_desc = spa_aprintf(_("%s [ALSA UCM error]"), desc);
pa_log_notice("Errors in ALSA UCM profile for card %s", desc);
if (new_desc)
pa_proplist_sets(impl->proplist, PA_PROP_DEVICE_DESCRIPTION, new_desc);
free(new_desc);
}
pa_dynarray_init(&impl->out.ports, NULL);
n_ports = 0;
PA_HASHMAP_FOREACH(dp, impl->ports, state) {