From b9a8bb15a4094e02108212e80bdfc83e65aec4be Mon Sep 17 00:00:00 2001
From: Wim Taymans <wtaymans@redhat.com>
Date: Mon, 19 May 2025 09:45:05 +0200
Subject: [PATCH] impl-link: fix feedback handling

If a link is a feedback link, we just need to swap the input/output
scheduling dependency.

Don't swap input/output nodes (without swapping ports) because then we
will be querying the wrong node/port pair when negotiating and cause
errors.

See #4706
---
 src/pipewire/impl-link.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/src/pipewire/impl-link.c b/src/pipewire/impl-link.c
index 5b38117e4..c764f445e 100644
--- a/src/pipewire/impl-link.c
+++ b/src/pipewire/impl-link.c
@@ -1536,14 +1536,8 @@ struct pw_impl_link *pw_context_create_link(struct pw_context *context,
 
 	impl->input.port = input;
 	impl->output.port = output;
-	if (this->feedback) {
-		impl->input.node = output_node;
-		impl->output.node = input_node;
-	}
-	else {
-		impl->output.node = output_node;
-		impl->input.node = input_node;
-	}
+	impl->output.node = output_node;
+	impl->input.node = input_node;
 	impl->input.mix = &this->rt.in_mix;
 	impl->output.mix = &this->rt.out_mix;
 
@@ -1569,8 +1563,12 @@ struct pw_impl_link *pw_context_create_link(struct pw_context *context,
 	pw_impl_port_recalc_tag(output);
 	pw_impl_port_recalc_tag(input);
 
-	if (impl->output.node != impl->input.node)
-		this->peer = pw_node_peer_ref(impl->output.node, impl->input.node);
+	if (impl->output.node != impl->input.node) {
+		if (this->feedback)
+			this->peer = pw_node_peer_ref(impl->input.node, impl->output.node);
+		else
+			this->peer = pw_node_peer_ref(impl->output.node, impl->input.node);
+	}
 
 	return this;