mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-14 06:59:57 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

stream: don't do overlapping assignment of union members

Browse source 
Coverity does not like assigning union member to another. Don't use
union here, as it's not needed.
This commit is contained in:
Pauli Virtanen 2022-07-20 15:34:45 +03:00 • committed by Wim Taymans
parent 67c41336db
commit b3db13be10
1 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

24
src/pipewire/stream.c
View file

@ -1261,11 +1261,9 @@ static int node_event_param(void *object, int seq,
{
struct spa_pod_prop *prop;
struct spa_pod_object *obj = (struct spa_pod_object *) param;
union {
float f;
double d;
bool b;
} value;
float value_f;
double value_d;
bool value_b;
float *values;
uint32_t i, n_values;
@ -1278,24 +1276,24 @@ static int node_event_param(void *object, int seq,
switch (c->container) {
case SPA_TYPE_Float:
if (spa_pod_get_float(&prop->value, &value.f) < 0)
if (spa_pod_get_float(&prop->value, &value_f) < 0)
continue;
n_values = 1;
values = &value.f;
values = &value_f;
break;
case SPA_TYPE_Double:
if (spa_pod_get_double(&prop->value, &value.d) < 0)
if (spa_pod_get_double(&prop->value, &value_d) < 0)
continue;
n_values = 1;
value.f = value.d;
values = &value.f;
value_f = value_d;
values = &value_f;
break;
case SPA_TYPE_Bool:
if (spa_pod_get_bool(&prop->value, &value.b) < 0)
if (spa_pod_get_bool(&prop->value, &value_b) < 0)
continue;
value.f = value.b ? 1.0f : 0.0f;
value_f = value_b ? 1.0f : 0.0f;
n_values = 1;
values = &value.f;
values = &value_f;
break;
case SPA_TYPE_Array:
if ((values = spa_pod_get_array(&prop->value, &n_values)) == NULL ||