mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

improve error messages

Browse source 
Log an error when we send an error to the client so that we don't need
to log and error anymore.
Improve the error messages when we can
Move some warnings and errors to debug
This commit is contained in:
Wim Taymans 2020-02-21 15:02:55 +01:00
parent ee617682c3
commit b33bd68bac
12 changed files with 56 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/modules/module-link-factory.c
View file

@ -285,36 +285,31 @@ static void *create_object(void *_data,
error_properties:
res = -EINVAL;
pw_log_error(NAME" usage:" FACTORY_USAGE);
pw_resource_error(resource, res, "no properties");
pw_resource_error(resource, res, NAME": no properties. usage:"FACTORY_USAGE);
goto error_exit;
error_output:
res = -EINVAL;
pw_log_error(NAME" unknown output node %u", output_node_id);
pw_resource_errorf(resource, res, "unknown output node %u", output_node_id);
pw_resource_errorf(resource, res, NAME": unknown output node %u", output_node_id);
goto error_exit;
error_input:
res = -EINVAL;
pw_log_error(NAME" unknown input node %u", input_node_id);
pw_resource_errorf(resource, res, "unknown input node %u", input_node_id);
pw_resource_errorf(resource, res, NAME": unknown input node %u", input_node_id);
goto error_exit;
error_output_port:
res = -EINVAL;
pw_log_error(NAME" unknown output port %u", output_port_id);
pw_resource_errorf(resource, res, "unknown output port %u", output_port_id);
pw_resource_errorf(resource, res, NAME": unknown output port %u", output_port_id);
goto error_exit;
error_input_port:
res = -EINVAL;
pw_log_error(NAME" unknown input port %u", input_port_id);
pw_resource_errorf(resource, res, "unknown input port %u", input_port_id);
pw_resource_errorf(resource, res, NAME": unknown input port %u", input_port_id);
goto error_exit;
error_create_link:
pw_log_error("can't create link: %s", spa_strerror(res));
pw_resource_errorf(resource, res, "can't create link: %s", spa_strerror(res));
pw_resource_errorf(resource, res, NAME": can't link ports %d and %d: %s",
pw_impl_port_get_id(outport), pw_impl_port_get_id(inport),
spa_strerror(res));
goto error_exit;
error_link_register:
pw_log_error("can't register link: %s", spa_strerror(res));
pw_resource_errorf(resource, res, "can't register link: %s", spa_strerror(res));
pw_resource_errorf(resource, res, NAME": can't register link: %s", spa_strerror(res));
goto error_exit;
error_exit:
if (properties)