mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

filter-chain: use offsets to deref pods

Browse source 
In a dynamic builder we can only save the offsets in the array and
deref after we completed building everything.

Increase the control limits.

See #2179
This commit is contained in:
Wim Taymans 2022-03-01 21:24:39 +01:00
parent 3d7ea3ee17
commit b324c02570
1 changed files with 14 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/modules/module-filter-chain.c
View file

@ -109,7 +109,7 @@ static const struct spa_dict_item module_props[] = {
#define MAX_HNDL 64 #define MAX_HNDL 64
#define MAX_PORTS 64 #define MAX_PORTS 64
#define MAX_CONTROLS 256 #define MAX_CONTROLS 512
#define MAX_SAMPLES 8192 #define MAX_SAMPLES 8192
static float silence_data[MAX_SAMPLES]; static float silence_data[MAX_SAMPLES];
@ -618,7 +618,8 @@ static int setup_streams(struct impl *impl)
{ {
int res; int res;
uint32_t i, n_params; uint32_t i, n_params;
const struct spa_pod *params[256]; uint32_t offsets[512];
const struct spa_pod *params[512];
struct spa_pod_dynamic_builder b; struct spa_pod_dynamic_builder b;
struct graph *graph = &impl->graph; struct graph *graph = &impl->graph;
@ -645,13 +646,20 @@ static int setup_streams(struct impl *impl)
n_params = 0; n_params = 0;
spa_pod_dynamic_builder_init(&b, NULL, 0, 4096); spa_pod_dynamic_builder_init(&b, NULL, 0, 4096);
params[n_params++] = spa_format_audio_raw_build(&b.b, offsets[n_params++] = b.b.state.offset;
spa_format_audio_raw_build(&b.b,
SPA_PARAM_EnumFormat, &impl->capture_info); SPA_PARAM_EnumFormat, &impl->capture_info);
for (i = 0; i < graph->n_control; i++) for (i = 0; i < graph->n_control; i++) {
params[n_params++] = get_prop_info(graph, &b.b, i); offsets[n_params++] = b.b.state.offset;
get_prop_info(graph, &b.b, i);
}
params[n_params++] = get_props_param(graph, &b.b); offsets[n_params++] = b.b.state.offset;
get_props_param(graph, &b.b);
for (i = 0; i < n_params; i++)
params[i] = spa_pod_builder_deref(&b.b, offsets[i]);
res = pw_stream_connect(impl->capture, res = pw_stream_connect(impl->capture,
PW_DIRECTION_INPUT, PW_DIRECTION_INPUT,