mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

node: handle async node_set_param

Browse source 
We block the client doing the call until the operation completes
with a sync on the node.
This commit is contained in:
Wim Taymans 2019-07-15 17:13:39 +02:00
parent 9b7d5c81e0
commit b0b379fc2a
1 changed files with 30 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

31
src/pipewire/node.c
View file

@ -69,6 +69,11 @@ struct resource_data {
uint32_t subscribe_ids[MAX_PARAMS]; uint32_t subscribe_ids[MAX_PARAMS];
uint32_t n_subscribe_ids; uint32_t n_subscribe_ids;
/* for async replies */
int seq;
int end;
struct spa_hook listener;
}; };
/** \endcond */ /** \endcond */
@ -384,21 +389,45 @@ static int node_subscribe_params(void *object, uint32_t *ids, uint32_t n_ids)
return 0; return 0;
} }
static void result_node_sync(void *data, int seq, int res, uint32_t type, const void *result)
{
struct resource_data *d = data;
pw_log_debug("sync result %d %d (%d/%d)", res, seq, d->seq, d->end);
if (seq == d->end) {
spa_hook_remove(&d->listener);
pw_client_set_busy(d->resource->client, false);
}
}
static int node_set_param(void *object, uint32_t id, uint32_t flags, static int node_set_param(void *object, uint32_t id, uint32_t flags,
const struct spa_pod *param) const struct spa_pod *param)
{ {
struct pw_resource *resource = object; struct pw_resource *resource = object;
struct resource_data *data = pw_resource_get_user_data(resource); struct resource_data *data = pw_resource_get_user_data(resource);
struct pw_node *node = data->node; struct pw_node *node = data->node;
struct pw_client *client = resource->client;
int res; int res;
static const struct spa_node_events node_events = {
SPA_VERSION_NODE_EVENTS,
.result = result_node_sync,
};
pw_log_debug("resource %p: set param %s %08x", resource, pw_log_debug("resource %p: set param %s %08x", resource,
spa_debug_type_find_name(spa_type_param, id), flags); spa_debug_type_find_name(spa_type_param, id), flags);
if ((res = spa_node_set_param(node->node, id, flags, param)) < 0) { res = spa_node_set_param(node->node, id, flags, param);
if (res < 0) {
pw_log_error("resource %p: %d error %d (%s)", resource, pw_log_error("resource %p: %d error %d (%s)", resource,
resource->id, res, spa_strerror(res)); resource->id, res, spa_strerror(res));
pw_resource_error(resource, res, spa_strerror(res)); pw_resource_error(resource, res, spa_strerror(res));
} else if (SPA_RESULT_IS_ASYNC(res)) {
spa_node_add_listener(node->node, &data->listener,
&node_events, data);
data->seq = res;
data->end = spa_node_sync(node->node, res);
pw_client_set_busy(client, true);
} }
return 0; return 0;
} }