mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-19 08:57:14 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pulse-server: module: do not schedule unloading multiple times

Browse source 
While it is not a problem since `module_free()` calls
`pw_work_queue_cancel()`, it is completely unnecessary
to do it more than once.

Introduce a new flag on the module which stores whether or
not an unloading has been scheduled.
This commit is contained in:
Barnabás Pőcze 2021-12-28 19:21:01 +01:00 • committed by Wim Taymans
parent 4fbe3cbfc6
commit b08da23715
2 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/modules/module-protocol-pulse/module.c
View file

@ -50,8 +50,11 @@ static void on_module_unload(void *obj, void *data, int res, uint32_t id)
void module_schedule_unload(struct module *module) void module_schedule_unload(struct module *module)
{ {
struct impl *impl = module->impl; if (module->unloading)
pw_work_queue_add(impl->work_queue, module, 0, on_module_unload, impl); return;
pw_work_queue_add(module->impl->work_queue, module, 0, on_module_unload, NULL);
module->unloading = true;
} }
struct module *module_new(struct impl *impl, const struct module_methods *methods, size_t user_data) struct module *module_new(struct impl *impl, const struct module_methods *methods, size_t user_data)

1
src/modules/module-protocol-pulse/module.h
View file

@ -66,6 +66,7 @@ struct module {
struct spa_hook_list listener_list; struct spa_hook_list listener_list;
void *user_data; void *user_data;
unsigned int loaded:1; unsigned int loaded:1;
unsigned int unloading:1;
}; };
#define module_emit_loaded(m,r) spa_hook_list_call(&m->listener_list, struct module_events, loaded, 0, r) #define module_emit_loaded(m,r) spa_hook_list_call(&m->listener_list, struct module_events, loaded, 0, r)