mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix possible leak

Browse source 
If pw_check_flatpak() sets app_id, its value will leak when
calling pw_snap_get_audio_permissions(). This patch fixes
this.
This commit is contained in:
Sergio Costas Rodriguez 2023-11-22 13:15:42 +01:00 • committed by Wim Taymans
parent abc4bd111b
commit ae11e61105
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/modules/module-protocol-pulse/server.c
View file

@ -410,7 +410,7 @@ on_connect(void *data, int fd, uint32_t mask)
client_access = server->client_access; client_access = server->client_access;
if (server->addr.ss_family == AF_UNIX) { if (server->addr.ss_family == AF_UNIX) {
spa_autofree char *app_id = NULL, *devices = NULL; spa_autofree char *app_id = NULL, *snap_app_id = NULL, *devices = NULL;
#ifdef HAVE_SNAP #ifdef HAVE_SNAP
pw_sandbox_access_t snap_access; pw_sandbox_access_t snap_access;
#endif #endif
@ -454,9 +454,9 @@ on_connect(void *data, int fd, uint32_t mask)
} }
// check SNAP permissions // check SNAP permissions
#ifdef HAVE_SNAP #ifdef HAVE_SNAP
snap_access = pw_snap_get_audio_permissions(client, client_fd, &app_id); snap_access = pw_snap_get_audio_permissions(client, client_fd, &snap_app_id);
if ((snap_access & PW_SANDBOX_ACCESS_NOT_A_SANDBOX) == 0) { if ((snap_access & PW_SANDBOX_ACCESS_NOT_A_SANDBOX) == 0) {
pw_properties_set(client->props, PW_KEY_SNAP_ID, app_id); pw_properties_set(client->props, PW_KEY_SNAP_ID, snap_app_id);
pw_properties_set(client->props, pw_properties_set(client->props,
PW_KEY_SNAP_PLAYBACK_ALLOWED, PW_KEY_SNAP_PLAYBACK_ALLOWED,