mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-18 08:56:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

context: fixup integer overflow

Browse source
This commit is contained in:
Pauli Virtanen 2021-09-04 17:13:29 +03:00 • committed by Wim Taymans
parent 18dde01d87
commit abc01083d4
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/pipewire/context.c
View file

@ -1132,9 +1132,12 @@ static uint32_t flp2(uint32_t x)
return x - (x >> 1); return x - (x >> 1);
} }
static int64_t fraction_compare(const struct spa_fraction *a, const struct spa_fraction *b) /* cmp fractions, avoiding overflows */
static int fraction_compare(const struct spa_fraction *a, const struct spa_fraction *b)
{ {
return (int64_t)(a->num * b->denom) - (int64_t)(b->num * a->denom); uint64_t fa = (uint64_t)a->num * (uint64_t)b->denom;
uint64_t fb = (uint64_t)b->num * (uint64_t)a->denom;
return fa < fb ? -1 : (fa > fb ? 1 : 0);
} }
int pw_context_recalc_graph(struct pw_context *context, const char *reason) int pw_context_recalc_graph(struct pw_context *context, const char *reason)