From ab71d2c3cbf8b95b0f6323d4f2e8539a458f4426 Mon Sep 17 00:00:00 2001 From: Konstantin Kharlamov Date: Fri, 25 Jun 2021 02:20:54 +0300 Subject: [PATCH] audioconvert: fix potential NULL reference in resample_native_init MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That was found by GCC fanalyze pass. Fixes warning: ../spa/plugins/audioconvert/resample-native.c: In function ‘resample_native_init’: ../spa/plugins/audioconvert/resample-native.c:385:9: warning: dereference of NULL ‘0B’ [CWE-476] [-Wanalyzer-null-dereference] 385 | spa_log_debug(r->log, "native %p: q:%d in:%d out:%d n_taps:%d n_phases:%d features:%08x:%08x", --- spa/plugins/audioconvert/resample-native.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/spa/plugins/audioconvert/resample-native.c b/spa/plugins/audioconvert/resample-native.c index 0438269ec..87d5ed9be 100644 --- a/spa/plugins/audioconvert/resample-native.c +++ b/spa/plugins/audioconvert/resample-native.c @@ -381,6 +381,11 @@ int resample_native_init(struct resample *r) build_filter(d->filter, d->filter_stride, n_taps, n_phases, scale); d->info = find_resample_info(SPA_AUDIO_FORMAT_F32, r->cpu_flags); + if (SPA_UNLIKELY(!d->info)) + { + spa_log_error(r->log, "failed to find suitable resample format!"); + return -1; + } spa_log_debug(r->log, "native %p: q:%d in:%d out:%d n_taps:%d n_phases:%d features:%08x:%08x", r, r->quality, in_rate, out_rate, n_taps, n_phases,