mirror of
				https://gitlab.freedesktop.org/pipewire/pipewire.git
				synced 2025-11-03 09:01:54 -05:00 
			
		
		
		
	cleanups and debug improvements
This commit is contained in:
		
							parent
							
								
									a9cb74f908
								
							
						
					
					
						commit
						a9bce3803a
					
				
					 4 changed files with 8 additions and 8 deletions
				
			
		| 
						 | 
					@ -263,14 +263,14 @@ static int impl_node_send_command(void *object, const struct spa_command *comman
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if ((res = spa_node_send_command(this->target, command)) < 0) {
 | 
						if ((res = spa_node_send_command(this->target, command)) < 0) {
 | 
				
			||||||
		spa_log_error(this->log, NAME " %p: can start convert: %s",
 | 
							spa_log_error(this->log, NAME " %p: can't start convert: %s",
 | 
				
			||||||
				this, spa_strerror(res));
 | 
									this, spa_strerror(res));
 | 
				
			||||||
		return res;
 | 
							return res;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (this->target != this->slave) {
 | 
						if (this->target != this->slave) {
 | 
				
			||||||
		if ((res = spa_node_send_command(this->slave, command)) < 0) {
 | 
							if ((res = spa_node_send_command(this->slave, command)) < 0) {
 | 
				
			||||||
			spa_log_error(this->log, NAME " %p: can start slave: %s",
 | 
								spa_log_error(this->log, NAME " %p: can't start slave: %s",
 | 
				
			||||||
					this, spa_strerror(res));
 | 
										this, spa_strerror(res));
 | 
				
			||||||
			return res;
 | 
								return res;
 | 
				
			||||||
		}
 | 
							}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -820,8 +820,8 @@ impl_node_port_set_io(void *object,
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	spa_return_val_if_fail(this != NULL, -EINVAL);
 | 
						spa_return_val_if_fail(this != NULL, -EINVAL);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	spa_log_debug(this->log, NAME " %p: set io %d on port %d:%d",
 | 
						spa_log_debug(this->log, NAME " %p: set io %d on port %d:%d %p",
 | 
				
			||||||
			this, id, direction, port_id);
 | 
								this, id, direction, port_id, data);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	spa_return_val_if_fail(CHECK_PORT(this, direction, port_id), -EINVAL);
 | 
						spa_return_val_if_fail(CHECK_PORT(this, direction, port_id), -EINVAL);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -577,11 +577,12 @@ static int do_allocation(struct pw_link *this)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	pw_link_update_state(this, PW_LINK_STATE_ALLOCATING, NULL);
 | 
						pw_link_update_state(this, PW_LINK_STATE_ALLOCATING, NULL);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	pw_log_debug("link %p: doing alloc buffers %p %p", this, output->node, input->node);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	in_flags = input->spa_flags;
 | 
						in_flags = input->spa_flags;
 | 
				
			||||||
	out_flags = output->spa_flags;
 | 
						out_flags = output->spa_flags;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
						pw_log_debug("link %p: doing alloc buffers %p %p: in_flags:%08x out_flags:%08x",
 | 
				
			||||||
 | 
								this, output->node, input->node, in_flags, out_flags);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	if (out_flags & SPA_PORT_FLAG_LIVE) {
 | 
						if (out_flags & SPA_PORT_FLAG_LIVE) {
 | 
				
			||||||
		pw_log_debug("setting link as live");
 | 
							pw_log_debug("setting link as live");
 | 
				
			||||||
		output->node->live = true;
 | 
							output->node->live = true;
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
| 
						 | 
					@ -232,9 +232,8 @@ static int update_properties(struct pw_port *port, const struct spa_dict *dict)
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	changed = pw_properties_update(port->properties, dict);
 | 
						changed = pw_properties_update(port->properties, dict);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
	pw_log_debug("port %p: updated %d properties", port, changed);
 | 
					 | 
				
			||||||
 | 
					 | 
				
			||||||
	if (changed) {
 | 
						if (changed) {
 | 
				
			||||||
 | 
							pw_log_debug("port %p: updated %d properties", port, changed);
 | 
				
			||||||
		port->info.props = &port->properties->dict;
 | 
							port->info.props = &port->properties->dict;
 | 
				
			||||||
		port->info.change_mask |= PW_PORT_CHANGE_MASK_PROPS;
 | 
							port->info.change_mask |= PW_PORT_CHANGE_MASK_PROPS;
 | 
				
			||||||
	}
 | 
						}
 | 
				
			||||||
| 
						 | 
					
 | 
				
			||||||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue