mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

improve debug

Browse source 
When we fail to read the eventfd, don't try to use the value.
This commit is contained in:
Wim Taymans 2020-05-20 13:33:55 +02:00
parent 1b2f64917e
commit a898f21c87
3 changed files with 3 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pipewire-jack/src/pipewire-jack.c
View file

@ -1004,8 +1004,7 @@ static inline uint32_t cycle_run(struct client *c)
pw_log_warn(NAME" %p: read failed %m", c); pw_log_warn(NAME" %p: read failed %m", c);
if (errno == EWOULDBLOCK) if (errno == EWOULDBLOCK)
return 0; return 0;
} } else if (SPA_UNLIKELY(cmd > 1))
if (SPA_UNLIKELY(cmd > 1))
pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", c, cmd - 1); pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", c, cmd - 1);
clock_gettime(CLOCK_MONOTONIC, &ts); clock_gettime(CLOCK_MONOTONIC, &ts);

2
src/modules/module-client-node/client-node.c
View file

@ -1085,7 +1085,7 @@ static void node_on_data_fd_events(struct spa_source *source)
if (SPA_UNLIKELY(spa_system_eventfd_read(this->data_system, if (SPA_UNLIKELY(spa_system_eventfd_read(this->data_system,
this->data_source.fd, &cmd) < 0)) this->data_source.fd, &cmd) < 0))
pw_log_warn(NAME" %p: read failed %m", this); pw_log_warn(NAME" %p: read failed %m", this);
if (SPA_UNLIKELY(cmd > 1)) else if (SPA_UNLIKELY(cmd > 1))
pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1); pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1);
spa_log_trace_fp(this->log, NAME" %p: got ready", this); spa_log_trace_fp(this->log, NAME" %p: got ready", this);

2
src/pipewire/impl-node.c
View file

@ -933,7 +933,7 @@ static void node_on_fd_events(struct spa_source *source)
if (SPA_UNLIKELY(spa_system_eventfd_read(data_system, this->source.fd, &cmd) < 0)) if (SPA_UNLIKELY(spa_system_eventfd_read(data_system, this->source.fd, &cmd) < 0))
pw_log_warn(NAME" %p: read failed %m", this); pw_log_warn(NAME" %p: read failed %m", this);
if (SPA_UNLIKELY(cmd > 1)) else if (SPA_UNLIKELY(cmd > 1))
pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1); pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1);
pw_log_trace_fp(NAME" %p: got process", this); pw_log_trace_fp(NAME" %p: got process", this);