diff --git a/src/modules/module-protocol-pulse/pulse-server.c b/src/modules/module-protocol-pulse/pulse-server.c index f6839af5c..95fb2b7aa 100644 --- a/src/modules/module-protocol-pulse/pulse-server.c +++ b/src/modules/module-protocol-pulse/pulse-server.c @@ -3646,7 +3646,8 @@ static int fill_card_info(struct client *client, struct message *m, pi = &port_info[n]; - if (pi->info && pi->n_props > 0) { + if (pi->info && pi->n_props > 0 && + pi->n_props <= MAX_ALLOCA_SIZE / sizeof(*items)) { items = alloca(pi->n_props * sizeof(*items)); dict.items = items; pdict = collect_props(pi->info, &dict); @@ -4100,6 +4101,9 @@ static int fill_node_info_proplist(struct message *m, const struct spa_dict *nod n_items += client_props->n_items; } + if (n_items > MAX_ALLOCA_SIZE / sizeof(struct spa_dict_item)) + return -ENOMEM; + dict.n_items = n = 0; dict.items = items = alloca(n_items * sizeof(struct spa_dict_item));