mirror of
				https://gitlab.freedesktop.org/pipewire/pipewire.git
				synced 2025-11-03 09:01:54 -05:00 
			
		
		
		
	context: improve state calculations
Always make peers of non-passive links runnable, even if we already visited the peer node. This makes non-passive links between drivers set the drivers to runnable. (midi-bridge, source to sink). It also makes nodes collected from the (link-)group runnable when they are linked together. To calculate the runnable state of the other nodes, only start from non-driver runnable nodes (like we already did when following links). This makes a link from echo-cancel-source to echo-cancel-sink activate the echo-canceler chain instead of staying idle.
This commit is contained in:
		
							parent
							
								
									0962555291
								
							
						
					
					
						commit
						a275e825c7
					
				
					 1 changed files with 4 additions and 6 deletions
				
			
		| 
						 | 
				
			
			@ -788,9 +788,6 @@ static inline int run_nodes(struct pw_context *context, struct pw_impl_node *nod
 | 
			
		|||
	struct pw_impl_port *p;
 | 
			
		||||
	struct pw_impl_link *l;
 | 
			
		||||
 | 
			
		||||
	if (!node->runnable)
 | 
			
		||||
		return 0;
 | 
			
		||||
 | 
			
		||||
	pw_log_debug("node %p: '%s'", node, node->name);
 | 
			
		||||
 | 
			
		||||
	spa_list_for_each(p, &node->input_ports, link) {
 | 
			
		||||
| 
						 | 
				
			
			@ -885,7 +882,7 @@ static int collect_nodes(struct pw_context *context, struct pw_impl_node *node,
 | 
			
		|||
 | 
			
		||||
				pw_impl_link_prepare(l);
 | 
			
		||||
 | 
			
		||||
				if (!l->prepared || (t != n && t->visited))
 | 
			
		||||
				if (!l->prepared)
 | 
			
		||||
					continue;
 | 
			
		||||
 | 
			
		||||
				if (!l->passive)
 | 
			
		||||
| 
						 | 
				
			
			@ -906,7 +903,7 @@ static int collect_nodes(struct pw_context *context, struct pw_impl_node *node,
 | 
			
		|||
 | 
			
		||||
				pw_impl_link_prepare(l);
 | 
			
		||||
 | 
			
		||||
				if (!l->prepared || (t != n && t->visited))
 | 
			
		||||
				if (!l->prepared)
 | 
			
		||||
					continue;
 | 
			
		||||
 | 
			
		||||
				if (!l->passive)
 | 
			
		||||
| 
						 | 
				
			
			@ -936,6 +933,7 @@ static int collect_nodes(struct pw_context *context, struct pw_impl_node *node,
 | 
			
		|||
		pw_log_debug(" next node %p: '%s' runnable:%u", n, n->name, n->runnable);
 | 
			
		||||
	}
 | 
			
		||||
	spa_list_for_each(n, collect, sort_link)
 | 
			
		||||
		if (!n->driver && n->runnable)
 | 
			
		||||
			run_nodes(context, n, collect);
 | 
			
		||||
 | 
			
		||||
	return 0;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue