From 999083105ca201466e32aeaaccb7c32c69d12dfc Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 25 Aug 2021 11:54:41 +0200 Subject: [PATCH] jack: protect against bad ports and buffers --- pipewire-jack/src/pipewire-jack.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pipewire-jack/src/pipewire-jack.c b/pipewire-jack/src/pipewire-jack.c index 7d20af1e9..dd5491b7d 100644 --- a/pipewire-jack/src/pipewire-jack.c +++ b/pipewire-jack/src/pipewire-jack.c @@ -4087,6 +4087,9 @@ void * jack_port_get_buffer (jack_port_t *port, jack_nframes_t frames) spa_return_val_if_fail(o != NULL, NULL); + if (o->type != INTERFACE_Port) + return NULL; + if ((p = o->port.port) == NULL) { struct mix *mix; struct buffer *b; @@ -5711,7 +5714,7 @@ SPA_EXPORT uint32_t jack_midi_get_event_count(void* port_buffer) { struct midi_buffer *mb = port_buffer; - if (mb == NULL) + if (mb == NULL || mb->magic != MIDI_BUFFER_MAGIC) return 0; return mb->event_count; }