mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

impl-core: avoid destroying the core object

Browse source 
Avoid destroying id 0 and return some errors.

See #560
This commit is contained in:
Wim Taymans 2021-01-11 13:18:11 +01:00
parent 6a9552a4ac
commit 9862560f55
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/pipewire/impl-core.c
View file

@ -102,7 +102,7 @@ static int registry_destroy(void *object, uint32_t id)
if (!PW_PERM_IS_R(permissions)) if (!PW_PERM_IS_R(permissions))
goto error_no_id; goto error_no_id;
if (!PW_PERM_IS_X(permissions)) if (id == PW_ID_CORE || !PW_PERM_IS_X(permissions))
goto error_not_allowed; goto error_not_allowed;
pw_log_debug("global %p: destroy global id %d", global, id); pw_log_debug("global %p: destroy global id %d", global, id);
@ -112,10 +112,12 @@ static int registry_destroy(void *object, uint32_t id)
error_no_id: error_no_id:
pw_log_debug("registry %p: no global with id %u to destroy", resource, id); pw_log_debug("registry %p: no global with id %u to destroy", resource, id);
pw_resource_errorf(resource, -ENOENT, "no global %u", id);
res = -ENOENT; res = -ENOENT;
goto error_exit; goto error_exit;
error_not_allowed: error_not_allowed:
pw_log_debug("registry %p: destroy of id %u not allowed", resource, id); pw_log_debug("registry %p: destroy of id %u not allowed", resource, id);
pw_resource_errorf(resource, -EPERM, "no permission to destroy %u", id);
res = -EPERM; res = -EPERM;
goto error_exit; goto error_exit;
error_exit: error_exit: