From 940ff7f53ba59db4a97de144b7c485c8638ba722 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Fri, 1 May 2020 11:19:34 +0200 Subject: [PATCH] client-node: improve error reporting Separate read failure and missed wakeup in 2 messages. --- src/modules/module-client-node/client-node.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/modules/module-client-node/client-node.c b/src/modules/module-client-node/client-node.c index ab5f40876..1df45f10b 100644 --- a/src/modules/module-client-node/client-node.c +++ b/src/modules/module-client-node/client-node.c @@ -1083,9 +1083,11 @@ static void node_on_data_fd_events(struct spa_source *source) if (source->rmask & SPA_IO_IN) { uint64_t cmd; - if (spa_system_eventfd_read(this->data_system, - this->data_source.fd, &cmd) < 0 || cmd != 1) - spa_log_warn(this->log, NAME" %p: read %"PRIu64" failed %m", this, cmd); + if (SPA_UNLIKELY(spa_system_eventfd_read(this->data_system, + this->data_source.fd, &cmd) < 0)) + pw_log_warn(NAME" %p: read failed %m", this); + if (SPA_UNLIKELY(cmd > 1)) + pw_log_warn(NAME" %p: missed %"PRIu64" wakeups", this, cmd - 1); spa_log_trace_fp(this->log, NAME" %p: got ready", this); spa_node_call_ready(&this->callbacks, SPA_STATUS_HAVE_DATA);