mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-05-30 21:37:53 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

filter-graph: error when there are no valid nodes

Browse source 
The nodes might have failed to load or there was an empty array or the
array did not contain objects.
This commit is contained in:
Wim Taymans 2026-05-07 13:30:41 +02:00
parent 142d3d7896
commit 925e071a26
2 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
spa/plugins/filter-graph/filter-graph.c
View file

@ -2092,6 +2092,10 @@ static int load_graph(struct graph *graph, const struct spa_dict *props)
if ((res = load_node(graph, &it[1])) < 0) if ((res = load_node(graph, &it[1])) < 0)
return res; return res;
} }
if (spa_list_is_empty(&graph->node_list)) {
spa_log_error(impl->log, "filter.graph has no nodes");
return -EINVAL;
}
if (plinks != NULL) { if (plinks != NULL) {
while (spa_json_enter_object(plinks, &it[1]) > 0) { while (spa_json_enter_object(plinks, &it[1]) > 0) {
if ((res = parse_link(graph, &it[1])) < 0) if ((res = parse_link(graph, &it[1])) < 0)
@ -2144,7 +2148,6 @@ static int load_graph(struct graph *graph, const struct spa_dict *props)
else else
graph->default_outputs = last->desc->n_output; graph->default_outputs = last->desc->n_output;
return 0; return 0;
} }

2
src/modules/module-filter-chain.c
View file

@ -1191,7 +1191,7 @@ static const struct pw_stream_events out_stream_events = {
static int setup_streams(struct impl *impl) static int setup_streams(struct impl *impl)
{ {
int res; int res = 0;
uint32_t i, n_params, *offs; uint32_t i, n_params, *offs;
struct pw_array offsets; struct pw_array offsets;
const struct spa_pod **params = NULL; const struct spa_pod **params = NULL;