mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-05-05 06:46:28 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

only dlopen from the defined search paths

Browse source 
Don't accept absolute library paths and skip the ../ in paths to avoid
opening arbitrary libraries from unexpected places.
This commit is contained in:
Wim Taymans 2026-04-06 14:18:22 +02:00
parent ad0bab69a1
commit 8fd7982087
4 changed files with 51 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spa/plugins/filter-graph/plugin_ladspa.c
View file

@ -236,12 +236,13 @@ static inline const char *split_walk(const char *str, const char *delimiter, siz
static int load_ladspa_plugin(struct plugin *impl, const char *path) static int load_ladspa_plugin(struct plugin *impl, const char *path)
{ {
int res = -ENOENT; int res = -ENOENT;
if (path[0] != '/') {
const char *search_dirs, *p, *state = NULL; const char *search_dirs, *p, *state = NULL;
char filename[PATH_MAX]; char filename[PATH_MAX];
size_t len; size_t len;
while ((p = strstr(path, "../")) != NULL)
path = p + 3;
search_dirs = getenv("LADSPA_PATH"); search_dirs = getenv("LADSPA_PATH");
if (!search_dirs) if (!search_dirs)
search_dirs = "/usr/lib64/ladspa:/usr/lib/ladspa:" LIBDIR; search_dirs = "/usr/lib64/ladspa:/usr/lib/ladspa:" LIBDIR;
@ -267,10 +268,6 @@ static int load_ladspa_plugin(struct plugin *impl, const char *path)
if (res >= 0) if (res >= 0)
break; break;
} }
}
else {
res = ladspa_handle_load_by_path(impl, path);
}
return res; return res;
} }

8
src/modules/module-jack-tunnel/weakjack.h
View file

@ -158,12 +158,13 @@ static inline int weakjack_load_by_path(struct weakjack *jack, const char *path)
static inline int weakjack_load(struct weakjack *jack, const char *lib) static inline int weakjack_load(struct weakjack *jack, const char *lib)
{ {
int res = -ENOENT; int res = -ENOENT;
if (lib[0] != '/') {
const char *search_dirs, *p, *state = NULL; const char *search_dirs, *p, *state = NULL;
char path[PATH_MAX]; char path[PATH_MAX];
size_t len; size_t len;
while ((p = strstr(lib, "../")) != NULL)
lib = p + 3;
search_dirs = getenv("LIBJACK_PATH"); search_dirs = getenv("LIBJACK_PATH");
if (!search_dirs) if (!search_dirs)
search_dirs = PREFIX "/lib64/:" PREFIX "/lib/:" search_dirs = PREFIX "/lib64/:" PREFIX "/lib/:"
@ -184,9 +185,6 @@ static inline int weakjack_load(struct weakjack *jack, const char *lib)
if ((res = weakjack_load_by_path(jack, path)) == 0) if ((res = weakjack_load_by_path(jack, path)) == 0)
break; break;
} }
} else {
res = weakjack_load_by_path(jack, lib);
}
return res; return res;
} }

3
src/pipewire/impl-module.c
View file

@ -154,6 +154,9 @@ pw_context_load_module(struct pw_context *context,
NULL NULL
}; };
while ((p = strstr(name, "../")) != NULL)
name = p + 3;
pw_log_info("%p: name:%s args:%s", context, name, args); pw_log_info("%p: name:%s args:%s", context, name, args);
module_dir = getenv("PIPEWIRE_MODULE_DIR"); module_dir = getenv("PIPEWIRE_MODULE_DIR");

3
src/pipewire/pipewire.c
View file

@ -232,6 +232,9 @@ static struct spa_handle *load_spa_handle(const char *lib,
if (lib == NULL) if (lib == NULL)
lib = sup->support_lib; lib = sup->support_lib;
while ((p = strstr(lib, "../")) != NULL)
lib = p + 3;
pw_log_debug("load lib:'%s' factory-name:'%s'", lib, factory_name); pw_log_debug("load lib:'%s' factory-name:'%s'", lib, factory_name);
plugin = NULL; plugin = NULL;