mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-04-09 08:21:08 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

only dlopen from the defined search paths

Browse source 
Don't accept absolute library paths and skip the ../ in paths to avoid
opening arbitrary libraries from unexpected places.
This commit is contained in:
Wim Taymans 2026-04-06 14:18:22 +02:00
parent ad0bab69a1
commit 8fd7982087
4 changed files with 51 additions and 50 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/modules/module-jack-tunnel/weakjack.h
View file

@ -158,34 +158,32 @@ static inline int weakjack_load_by_path(struct weakjack *jack, const char *path)
static inline int weakjack_load(struct weakjack *jack, const char *lib)
{
int res = -ENOENT;
const char *search_dirs, *p, *state = NULL;
char path[PATH_MAX];
size_t len;
if (lib[0] != '/') {
const char *search_dirs, *p, *state = NULL;
char path[PATH_MAX];
size_t len;
while ((p = strstr(lib, "../")) != NULL)
lib = p + 3;
search_dirs = getenv("LIBJACK_PATH");
if (!search_dirs)
search_dirs = PREFIX "/lib64/:" PREFIX "/lib/:"
"/usr/lib64/:/usr/lib/:" LIBDIR;
search_dirs = getenv("LIBJACK_PATH");
if (!search_dirs)
search_dirs = PREFIX "/lib64/:" PREFIX "/lib/:"
"/usr/lib64/:/usr/lib/:" LIBDIR;
while ((p = pw_split_walk(search_dirs, ":", &len, &state))) {
int pathlen;
while ((p = pw_split_walk(search_dirs, ":", &len, &state))) {
int pathlen;
if (len >= sizeof(path)) {
res = -ENAMETOOLONG;
continue;
}
pathlen = snprintf(path, sizeof(path), "%.*s/%s", (int) len, p, lib);
if (pathlen < 0 || (size_t) pathlen >= sizeof(path)) {
res = -ENAMETOOLONG;
continue;
}
if ((res = weakjack_load_by_path(jack, path)) == 0)
break;
if (len >= sizeof(path)) {
res = -ENAMETOOLONG;
continue;
}
} else {
res = weakjack_load_by_path(jack, lib);
pathlen = snprintf(path, sizeof(path), "%.*s/%s", (int) len, p, lib);
if (pathlen < 0 || (size_t) pathlen >= sizeof(path)) {
res = -ENAMETOOLONG;
continue;
}
if ((res = weakjack_load_by_path(jack, path)) == 0)
break;
}
return res;
}

3
src/pipewire/impl-module.c
View file

@ -154,6 +154,9 @@ pw_context_load_module(struct pw_context *context,
NULL
};
while ((p = strstr(name, "../")) != NULL)
name = p + 3;
pw_log_info("%p: name:%s args:%s", context, name, args);
module_dir = getenv("PIPEWIRE_MODULE_DIR");

3
src/pipewire/pipewire.c
View file

@ -232,6 +232,9 @@ static struct spa_handle *load_spa_handle(const char *lib,
if (lib == NULL)
lib = sup->support_lib;
while ((p = strstr(lib, "../")) != NULL)
lib = p + 3;
pw_log_debug("load lib:'%s' factory-name:'%s'", lib, factory_name);
plugin = NULL;