From 8e63aa3d10adc65fe2e220dc72ab017f3f6f164d Mon Sep 17 00:00:00 2001 From: Pauli Virtanen Date: Sun, 13 Feb 2022 13:39:49 +0200 Subject: [PATCH] pulse-server: fix some error checks in modules These should check if the previous pw_manager_new failed. --- src/modules/module-protocol-pulse/modules/module-combine-sink.c | 2 +- .../module-protocol-pulse/modules/module-zeroconf-publish.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/module-protocol-pulse/modules/module-combine-sink.c b/src/modules/module-protocol-pulse/modules/module-combine-sink.c index f5ceca5bd..b7e034698 100644 --- a/src/modules/module-protocol-pulse/modules/module-combine-sink.c +++ b/src/modules/module-protocol-pulse/modules/module-combine-sink.c @@ -381,7 +381,7 @@ static int module_combine_sink_load(struct client *client, struct module *module return res; data->manager = pw_manager_new(data->core); - if (client->manager == NULL) + if (data->manager == NULL) return -errno; pw_manager_add_listener(data->manager, &data->manager_listener, diff --git a/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c b/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c index fce8eff3b..5c5ae1989 100644 --- a/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c +++ b/src/modules/module-protocol-pulse/modules/module-zeroconf-publish.c @@ -591,7 +591,7 @@ static int module_zeroconf_publish_load(struct client *client, struct module *mo } data->manager = pw_manager_new(data->core); - if (client->manager == NULL) { + if (data->manager == NULL) { pw_log_error("failed to create pipewire manager: %m"); return -errno; }