From 8d019c5689e829ba3a77c4a36adde45e872c11ad Mon Sep 17 00:00:00 2001 From: Pauli Virtanen Date: Wed, 30 Oct 2024 19:16:35 +0200 Subject: [PATCH] pulse-server: more specific error message when too many connections This appears to be encountered often enough so a clearer message is maybe useful. --- src/modules/module-protocol-pulse/server.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/modules/module-protocol-pulse/server.c b/src/modules/module-protocol-pulse/server.c index 291007832..6ef6b71d4 100644 --- a/src/modules/module-protocol-pulse/server.c +++ b/src/modules/module-protocol-pulse/server.c @@ -356,6 +356,7 @@ on_connect(void *data, int fd, uint32_t mask) int client_fd, val; struct client *client = NULL; const char *client_access = NULL; + const char *error_reason = NULL; pid_t pid; length = sizeof(name); @@ -374,6 +375,7 @@ on_connect(void *data, int fd, uint32_t mask) if (server->n_clients >= server->max_clients) { close(client_fd); + error_reason = "too many client application connections"; errno = ECONNREFUSED; goto error; } @@ -487,7 +489,9 @@ on_connect(void *data, int fd, uint32_t mask) return; error: - pw_log_error("server %p: failed to create client: %m", server); + pw_log_error("server %p: %s: %m", server, + error_reason ? error_reason : "failed to create client"); + if (client) client_free(client); }