mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pipewiresink: release manually acquired buffers back to the pool

Browse source 
When we manually acquire buffers from the pool, we never release them.
But because gst_buffer_pool_acquire_buffer() adds a reference to the pool,
this leaks the pool eventually.

To fix this, just unref the buffer after it has been sent. This releases
it back to the pool and unrefs the pool.

This has no significant effect to the stream, since the underlying
pw buffers are actually pooled in the pw_stream. It just prevents leaking.
This commit is contained in:
George Kiagiadakis 2021-05-10 17:25:57 +03:00
parent b86e5cabfa
commit 8911e22793
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/gst/gstpipewiresink.c
View file

@ -578,6 +578,7 @@ gst_pipewire_sink_render (GstBaseSink * bsink, GstBuffer * buffer)
GstPipeWireSink *pwsink; GstPipeWireSink *pwsink;
GstFlowReturn res = GST_FLOW_OK; GstFlowReturn res = GST_FLOW_OK;
const char *error = NULL; const char *error = NULL;
gboolean unref_buffer = FALSE;
pwsink = GST_PIPEWIRE_SINK (bsink); pwsink = GST_PIPEWIRE_SINK (bsink);
@ -620,6 +621,7 @@ gst_pipewire_sink_render (GstBaseSink * bsink, GstBuffer * buffer)
gst_buffer_unmap (b, &info); gst_buffer_unmap (b, &info);
gst_buffer_resize (b, 0, gst_buffer_get_size (buffer)); gst_buffer_resize (b, 0, gst_buffer_get_size (buffer));
buffer = b; buffer = b;
unref_buffer = TRUE;
pw_thread_loop_lock (pwsink->core->loop); pw_thread_loop_lock (pwsink->core->loop);
if (pw_stream_get_state (pwsink->stream, &error) != PW_STREAM_STATE_STREAMING) if (pw_stream_get_state (pwsink->stream, &error) != PW_STREAM_STATE_STREAMING)
@ -628,6 +630,8 @@ gst_pipewire_sink_render (GstBaseSink * bsink, GstBuffer * buffer)
GST_DEBUG ("push buffer"); GST_DEBUG ("push buffer");
do_send_buffer (pwsink, buffer); do_send_buffer (pwsink, buffer);
if (unref_buffer)
gst_buffer_unref (buffer);
done_unlock: done_unlock:
pw_thread_loop_unlock (pwsink->core->loop); pw_thread_loop_unlock (pwsink->core->loop);