mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

alsa: Allow to augment ucm port properties

Browse source 
Since UCM doesn't perform the path lookups of alsa-mixer all UCM devices
fall back to the card's properties for e.g. icons and hence usually show
the `audio-card` icon for all ports giving a confusing UI to users as
all ports show the same icon.

As ucm names are pretty standard augment some common port names with
icons.
This commit is contained in:
Guido Günther 2023-06-20 21:27:46 +02:00 • committed by Wim Taymans
parent e4cc63a6dc
commit 88bb0bd7cc
1 changed files with 35 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

35
spa/plugins/alsa/acp/alsa-ucm.c
View file

@ -991,6 +991,40 @@ fail:
} }
} }
static void ucm_add_port_props(
pa_device_port *port,
bool is_sink)
{
const char *icon;
if (is_sink) {
switch (port->type) {
case PA_DEVICE_PORT_TYPE_HEADPHONES:
icon = "audio-headphones";
break;
case PA_DEVICE_PORT_TYPE_HDMI:
icon = "video-display";
break;
case PA_DEVICE_PORT_TYPE_SPEAKER:
default:
icon = "audio-speakers";
break;
}
} else {
switch (port->type) {
case PA_DEVICE_PORT_TYPE_HEADSET:
icon = "audio-headset";
break;
case PA_DEVICE_PORT_TYPE_MIC:
default:
icon = "audio-input-microphone";
break;
}
}
pa_proplist_sets(port->proplist, "device.icon_name", icon);
}
static void ucm_add_port_combination( static void ucm_add_port_combination(
pa_hashmap *hash, pa_hashmap *hash,
pa_alsa_ucm_mapping_context *context, pa_alsa_ucm_mapping_context *context,
@ -1097,6 +1131,7 @@ static void ucm_add_port_combination(
pa_hashmap_put(ports, port->name, port); pa_hashmap_put(ports, port->name, port);
pa_log_debug("Add port %s: %s", port->name, port->description); pa_log_debug("Add port %s: %s", port->name, port->description);
ucm_add_port_props(port, is_sink);
if (num == 1) { if (num == 1) {
/* To keep things simple and not worry about stacking controls, we only support hardware volumes on non-combination /* To keep things simple and not worry about stacking controls, we only support hardware volumes on non-combination