mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-17 07:00:03 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

impl-client: improve permission storage

Browse source 
Now that the globals are not reused we can't store the permissions in an
array indexed by the id anymore.

Store the permissions in a sparse array instead and do a linear search
for them.

See !1108
This commit is contained in:
Wim Taymans 2022-01-14 09:55:58 +01:00
parent 8ca037683e
commit 888716a871
1 changed files with 24 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

57
src/pipewire/impl-client.c
View file

@ -58,46 +58,36 @@ static struct pw_permission *
find_permission(struct pw_impl_client *client, uint32_t id) find_permission(struct pw_impl_client *client, uint32_t id)
{ {
struct impl *impl = SPA_CONTAINER_OF(client, struct impl, this); struct impl *impl = SPA_CONTAINER_OF(client, struct impl, this);
struct pw_permission *p; struct pw_permission *p, *def = NULL;
uint32_t idx = id + 1;
if (id == PW_ID_ANY)
goto do_default;
if (!pw_array_check_index(&impl->permissions, idx, struct pw_permission))
goto do_default;
p = pw_array_get_unchecked(&impl->permissions, idx, struct pw_permission);
if (p->permissions == PW_PERM_INVALID)
goto do_default;
pw_array_for_each(p, &impl->permissions) {
if (p->id == id && p->permissions != PW_PERM_INVALID)
return p; return p;
else if (def == NULL && p->id == PW_ID_ANY)
do_default: def = p;
return pw_array_get_unchecked(&impl->permissions, 0, struct pw_permission); }
return def;
} }
static struct pw_permission *ensure_permissions(struct pw_impl_client *client, uint32_t id) static struct pw_permission *ensure_permissions(struct pw_impl_client *client, uint32_t id)
{ {
struct impl *impl = SPA_CONTAINER_OF(client, struct impl, this); struct impl *impl = SPA_CONTAINER_OF(client, struct impl, this);
struct pw_permission *p; struct pw_permission *p, *free = NULL;
uint32_t idx = id + 1;
size_t len, i;
len = pw_array_get_len(&impl->permissions, struct pw_permission); pw_array_for_each(p, &impl->permissions) {
if (len <= idx) { if (p->id == id)
size_t diff = idx - len + 1;
p = pw_array_add(&impl->permissions, diff * sizeof(struct pw_permission));
if (p == NULL)
return NULL;
for (i = 0; i < diff; i++) {
p[i] = PW_PERMISSION_INIT(len + i - 1, PW_PERM_INVALID);
}
}
p = pw_array_get_unchecked(&impl->permissions, idx, struct pw_permission);
return p; return p;
else if (free == NULL && p->permissions == PW_PERM_INVALID)
free = p;
}
if (free == NULL) {
if ((free = pw_array_add(&impl->permissions,
sizeof(struct pw_permission))) == NULL)
return NULL;
}
free->id = id;
free->permissions = PW_PERM_INVALID;
return free;
} }
/** \endcond */ /** \endcond */
@ -414,7 +404,7 @@ struct pw_impl_client *pw_context_create_client(struct pw_impl_core *core,
goto error_free; goto error_free;
} }
pw_array_init(&impl->permissions, 1024); pw_array_init(&impl->permissions, 64);
p = pw_array_add(&impl->permissions, sizeof(struct pw_permission)); p = pw_array_add(&impl->permissions, sizeof(struct pw_permission));
if (p == NULL) { if (p == NULL) {
res = -errno; res = -errno;
@ -689,8 +679,7 @@ int pw_impl_client_update_permissions(struct pw_impl_client *client,
pw_log_warn("%p: invalid global %d", client, permissions[i].id); pw_log_warn("%p: invalid global %d", client, permissions[i].id);
continue; continue;
} }
p = ensure_permissions(client, permissions[i].id); if ((p = ensure_permissions(client, permissions[i].id)) == NULL) {
if (p == NULL) {
pw_log_warn("%p: can't ensure permission: %m", client); pw_log_warn("%p: can't ensure permission: %m", client);
return -errno; return -errno;
} }