mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-01 22:58:50 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Use the DSP format for dsp formats

Browse source 
Use the DSP media subtype to describe DSP formats. DSP formats
don't include the rate, channels and channel position in the
format and must use the rate and duration from the position io. This
makes it possible to later change the samplerate dynamically without
having to renegotiate the graph.

The same goes for the video DSP format, which uses the io_video_size
from the io_position to get the size/stride. Set this up in the node
based on the defaults from the context.

Make it possible to define defaults in the daemon config file, such
as samplerate, quantum, video size and framerate. This is stored in
the context and used for the DSP formats.
This commit is contained in:
Wim Taymans 2020-01-09 13:40:48 +01:00
parent 5a6da7d5e1
commit 852ac043d3
20 changed files with 402 additions and 270 deletions
Download patch file Download diff file Expand all files Collapse all files

28
spa/plugins/jack/jack-sink.c
View file

@ -146,8 +146,8 @@ static int impl_node_enum_params(void *object, int seq,
case SPA_PARAM_Format:
switch (result.index) {
case 0:
param = spa_format_audio_raw_build(&b,
id, &this->current_format.info.raw);
param = spa_format_audio_dsp_build(&b,
id, &this->current_format.info.dsp);
break;
default:
return 0;
@ -447,11 +447,8 @@ static int init_ports(struct impl *this)
}
this->n_in_ports = i;
this->current_format.info.raw = SPA_AUDIO_INFO_RAW_INIT(
.format = SPA_AUDIO_FORMAT_F32P,
.flags = SPA_AUDIO_FLAG_UNPOSITIONED,
.rate = jack_get_sample_rate(client),
.channels = this->n_in_ports);
this->current_format.info.dsp = SPA_AUDIO_INFO_DSP_INIT(
.format = SPA_AUDIO_FORMAT_DSP_F32);
spa_jack_client_add_listener(this->client,
&this->client_listener,
@ -499,10 +496,8 @@ static int port_enum_formats(struct impl *this,
*param = spa_pod_builder_add_object(builder,
SPA_TYPE_OBJECT_Format, SPA_PARAM_EnumFormat,
SPA_FORMAT_mediaType, SPA_POD_Id(SPA_MEDIA_TYPE_audio),
SPA_FORMAT_mediaSubtype, SPA_POD_Id(SPA_MEDIA_SUBTYPE_raw),
SPA_FORMAT_AUDIO_format, SPA_POD_Id(SPA_AUDIO_FORMAT_F32P),
SPA_FORMAT_AUDIO_rate, SPA_POD_Int(this->client->frame_rate),
SPA_FORMAT_AUDIO_channels, SPA_POD_Int(1));
SPA_FORMAT_mediaSubtype, SPA_POD_Id(SPA_MEDIA_SUBTYPE_dsp),
SPA_FORMAT_AUDIO_format, SPA_POD_Id(SPA_AUDIO_FORMAT_DSP_F32));
break;
default:
return 0;
@ -552,7 +547,7 @@ impl_node_port_enum_params(void *object, int seq,
if (result.index > 0)
return 0;
param = spa_format_audio_raw_build(&b, id, &port->current_format.info.raw);
param = spa_format_audio_dsp_build(&b, id, &port->current_format.info.dsp);
break;
case SPA_PARAM_Buffers:
@ -627,17 +622,16 @@ static int port_set_format(struct impl *this, struct port *port,
return res;
if (info.media_type != SPA_MEDIA_TYPE_audio &&
info.media_subtype != SPA_MEDIA_SUBTYPE_raw)
info.media_subtype != SPA_MEDIA_SUBTYPE_dsp)
return -EINVAL;
if (spa_format_audio_raw_parse(format, &info.info.raw) < 0)
if (spa_format_audio_dsp_parse(format, &info.info.dsp) < 0)
return -EINVAL;
if (info.info.raw.format == SPA_AUDIO_FORMAT_F32P)
port->stride = 4;
else
if (info.info.dsp.format != SPA_AUDIO_FORMAT_DSP_F32)
return -EINVAL;
port->stride = 4;
port->current_format = info;
port->have_format = true;
}

28
spa/plugins/jack/jack-source.c
View file

@ -148,8 +148,8 @@ static int impl_node_enum_params(void *object, int seq,
case SPA_PARAM_Format:
switch (result.index) {
case 0:
param = spa_format_audio_raw_build(&b,
id, &this->current_format.info.raw);
param = spa_format_audio_dsp_build(&b,
id, &this->current_format.info.dsp);
break;
default:
return 0;
@ -446,11 +446,8 @@ static int init_ports(struct impl *this)
}
this->n_out_ports = i;
this->current_format.info.raw = SPA_AUDIO_INFO_RAW_INIT(
.format = SPA_AUDIO_FORMAT_F32P,
.flags = SPA_AUDIO_FLAG_UNPOSITIONED,
.rate = jack_get_sample_rate(client),
.channels = this->n_out_ports);
this->current_format.info.dsp = SPA_AUDIO_INFO_DSP_INIT(
.format = SPA_AUDIO_FORMAT_DSP_F32);
spa_jack_client_add_listener(this->client,
&this->client_listener,
@ -498,10 +495,8 @@ static int port_enum_formats(struct impl *this,
*param = spa_pod_builder_add_object(builder,
SPA_TYPE_OBJECT_Format, SPA_PARAM_EnumFormat,
SPA_FORMAT_mediaType, SPA_POD_Id(SPA_MEDIA_TYPE_audio),
SPA_FORMAT_mediaSubtype, SPA_POD_Id(SPA_MEDIA_SUBTYPE_raw),
SPA_FORMAT_AUDIO_format, SPA_POD_Id(SPA_AUDIO_FORMAT_F32P),
SPA_FORMAT_AUDIO_rate, SPA_POD_Int(this->client->frame_rate),
SPA_FORMAT_AUDIO_channels, SPA_POD_Int(1));
SPA_FORMAT_mediaSubtype, SPA_POD_Id(SPA_MEDIA_SUBTYPE_dsp),
SPA_FORMAT_AUDIO_format, SPA_POD_Id(SPA_AUDIO_FORMAT_DSP_F32));
break;
default:
return 0;
@ -551,7 +546,7 @@ impl_node_port_enum_params(void *object, int seq,
if (result.index > 0)
return 0;
param = spa_format_audio_raw_build(&b, id, &port->current_format.info.raw);
param = spa_format_audio_dsp_build(&b, id, &port->current_format.info.dsp);
break;
case SPA_PARAM_Buffers:
@ -627,17 +622,16 @@ static int port_set_format(struct impl *this, struct port *port,
return res;
if (info.media_type != SPA_MEDIA_TYPE_audio &&
info.media_subtype != SPA_MEDIA_SUBTYPE_raw)
info.media_subtype != SPA_MEDIA_SUBTYPE_dsp)
return -EINVAL;
if (spa_format_audio_raw_parse(format, &info.info.raw) < 0)
if (spa_format_audio_dsp_parse(format, &info.info.dsp) < 0)
return -EINVAL;
if (info.info.raw.format == SPA_AUDIO_FORMAT_F32P)
port->stride = 4;
else
if (info.info.dsp.format != SPA_AUDIO_FORMAT_DSP_F32)
return -EINVAL;
port->stride = 4;
port->current_format = info;
port->have_format = true;
}