mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

media-session: switch to the route when availability changed

Browse source 
When a user plugs in headphones, they expect to hear an audio through
them. Currently, that usecase might or might not work with pipewire
depending on the user's luck, because pipewire instead uses port
priorities, and those apparently rarely have sane default values.

PulseAudio ignored priorities here, instead it made use of the port
right away. This should better match user expectations (who plugged in
headphones and is expecting to hear sound), so let's do the same in
pipewire.

Fixes: https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1170
This commit is contained in:
Konstantin Kharlamov 2021-06-13 21:40:12 +03:00 • committed by Wim Taymans
parent 3512977450
commit 84acfbbda5
1 changed files with 22 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

28
src/examples/media-session/default-routes.c
View file

@ -566,13 +566,29 @@ static int find_best_route(struct device *dev, uint32_t device_id, struct route
parse_enum_route(p, device_id, &t) < 0) parse_enum_route(p, device_id, &t) < 0)
continue; continue;
if (t.available == SPA_PARAM_AVAILABILITY_yes) { if (t.available == SPA_PARAM_AVAILABILITY_yes || t.available == SPA_PARAM_AVAILABILITY_unknown) {
if (best_avail.name == NULL || t.priority > best_avail.priority) struct route_info *ri;
if ((ri = find_route_info(dev, &t)) && ri->direction == SPA_DIRECTION_OUTPUT &&
ri->available != ri->prev_available) {
/* If route availability changed, that means a user just
* plugged in something like headphones, and they probably
* expect to hear sound from it. Switch to it immediately.
*
* TODO: switch INPUT ports without source and the input
* ports their source->active_port is part of a group of
* ports (see module-switch-on-port-available.c in PulseAudio).
*/
best_avail = t; best_avail = t;
} ri->save = true;
else if (t.available != SPA_PARAM_AVAILABILITY_no) { break;
if (best_unk.name == NULL || t.priority > best_unk.priority) }
best_unk = t; else if (t.available == SPA_PARAM_AVAILABILITY_yes) {
if (best_avail.name == NULL || t.priority > best_avail.priority)
best_avail = t;
} else { // SPA_PARAM_AVAILABILITY_unknown
if (best_unk.name == NULL || t.priority > best_unk.priority)
best_unk = t;
}
} }
} }
best = best_avail; best = best_avail;