mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

data-loop: optimize iterate dispatch

Browse source 
Avoid doing the interface unref and version check for each iteration but
do this before entering the loop. Improves performance in high frequency
wakeups.
This commit is contained in:
Wim Taymans 2023-05-05 17:43:27 +02:00
parent fbf17cf980
commit 8452e6d28e
1 changed files with 13 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/pipewire/data-loop.c
View file

@ -51,6 +51,18 @@ static void *do_loop(void *user_data)
{
struct pw_data_loop *this = user_data;
int res;
int (*iterate) (void *object, int timeout);
struct spa_interface *iface = &this->loop->control->iface;
struct spa_callbacks *cb = &iface->cb;
const struct spa_loop_control_methods *m =
(const struct spa_loop_control_methods *)cb->funcs;
void *data = cb->data;
if (!SPA_CALLBACK_CHECK(m, iterate, 0)) {
pw_log_error("loop is missing iterate method");
return NULL;
}
iterate = m->iterate;
pw_log_debug("%p: enter thread", this);
pw_loop_enter(this->loop);
@ -58,7 +70,7 @@ static void *do_loop(void *user_data)
pthread_cleanup_push(thread_cleanup, this);
while (SPA_LIKELY(this->running)) {
if (SPA_UNLIKELY((res = pw_loop_iterate(this->loop, -1)) < 0)) {
if (SPA_UNLIKELY((res = iterate(data, -1)) < 0)) {
if (res == -EINTR)
continue;
pw_log_error("%p: iterate error %d (%s)",