mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-04 13:30:12 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

proxy: invalidate proxy id when removed from map

Browse source 
Client-side bugs calling methods on destroyed proxies like

    pw_proxy_ref(p);
    pw_proxy_destroy(p);
    ...
    wait for server to ack the remove
    ...
    pw_core_destroy(p->core, p); /* p already removed & destroyed */

should not send messages with the stale proxy id to server.

Set id to SPA_ID_INVALID when removing a proxy from the id map, so that
such client bugs only result to ENOENT.
This commit is contained in:
Pauli Virtanen 2024-10-23 18:45:47 +03:00 • committed by Wim Taymans
parent 24e1603f81
commit 7f885a2e94
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/pipewire/proxy.c
View file

@ -191,6 +191,9 @@ static inline void remove_from_map(struct pw_proxy *proxy)
if (proxy->core) if (proxy->core)
pw_map_remove(&proxy->core->objects, proxy->id); pw_map_remove(&proxy->core->objects, proxy->id);
proxy->in_map = false; proxy->in_map = false;
/* Make sure any future method calls fail */
proxy->id = SPA_ID_INVALID;
} }
} }