mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

audioadapter: negotiate formats from output to input

Browse source 
Try to avoid conversions by taking the output port format and using that
as a filter for the input port format.

Because filtering pods prefer the values of the filter, this will prefer
the output format values and thus avoid conversions.
This commit is contained in:
Wim Taymans 2025-03-24 11:39:20 +01:00
parent de54cfc475
commit 7e67daa292
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spa/plugins/audioconvert/audioadapter.c
View file

@ -924,6 +924,7 @@ static int negotiate_format(struct impl *this)
uint8_t buffer[4096];
struct spa_pod_builder b = { 0 };
int res, fres;
struct spa_node *src, *dst;
spa_log_debug(this->log, "%p: have_format:%d recheck:%d", this, this->have_format,
this->recheck_format);
@ -941,6 +942,15 @@ static int negotiate_format(struct impl *this)
spa_node_send_command(this->follower,
&SPA_NODE_COMMAND_INIT(SPA_NODE_COMMAND_ParamBegin));
if (this->direction == SPA_DIRECTION_INPUT) {
src = this->target;
dst = this->follower;
} else {
src = this->follower;
dst = this->target;
}
/* first try the ideal converter format, which is likely passthrough */
tstate = 0;
fres = node_port_enum_params_sync(this, this->target,
@ -960,8 +970,8 @@ static int negotiate_format(struct impl *this)
/* then try something the follower can accept */
for (fstate = 0;;) {
format = NULL;
res = node_port_enum_params_sync(this, this->follower,
this->direction, 0,
res = node_port_enum_params_sync(this, src,
SPA_DIRECTION_OUTPUT, 0,
SPA_PARAM_EnumFormat, &fstate,
NULL, &format, &b);
@ -971,8 +981,8 @@ static int negotiate_format(struct impl *this)
break;
tstate = 0;
fres = node_port_enum_params_sync(this, this->target,
SPA_DIRECTION_REVERSE(this->direction), 0,
fres = node_port_enum_params_sync(this, dst,
SPA_DIRECTION_INPUT, 0,
SPA_PARAM_EnumFormat, &tstate,
format, &format, &b);
if (fres == 0 && res == 1)