mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-12-16 08:56:45 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pulse-server: improve Buffer param

Browse source 
We need to be able to fill up one quantum of data when the stream
requests it so suggest a quantum_limit buffer size. Normally, the
converter will further improve the buffer size parameters when
resampling is involved but this is a good default for when working in
passthrough mode.

We don't actually use the stream buffering features so we're happy with
just 1 or 2 buffers.
This commit is contained in:
Wim Taymans 2023-03-30 10:13:43 +02:00
parent 495a227e5e
commit 7bddb80c93
1 changed files with 7 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

19
src/modules/module-protocol-pulse/pulse-server.c
View file

@ -1154,30 +1154,25 @@ static const struct spa_pod *get_buffers_param(struct stream *s,
struct buffer_attr *attr, struct spa_pod_builder *b) struct buffer_attr *attr, struct spa_pod_builder *b)
{ {
const struct spa_pod *param; const struct spa_pod *param;
uint32_t blocks, buffers, size, maxsize, stride; uint32_t blocks, size, stride;
struct defs *defs = &s->impl->defs; struct defs *defs = &s->impl->defs;
blocks = 1; blocks = 1;
stride = s->frame_size; stride = s->frame_size;
maxsize = defs->quantum_limit * 32 * s->frame_size; size = defs->quantum_limit * s->frame_size;
if (s->direction == PW_DIRECTION_OUTPUT) {
size = attr->minreq;
} else {
size = attr->fragsize;
}
buffers = SPA_CLAMP(maxsize / size, MIN_BUFFERS, MAX_BUFFERS);
pw_log_info("[%s] stride %d maxsize %d size %u buffers %d", s->client->name, pw_log_info("[%s] stride %d size %u", s->client->name, stride, size);
stride, maxsize, size, buffers);
param = spa_pod_builder_add_object(b, param = spa_pod_builder_add_object(b,
SPA_TYPE_OBJECT_ParamBuffers, SPA_PARAM_Buffers, SPA_TYPE_OBJECT_ParamBuffers, SPA_PARAM_Buffers,
SPA_PARAM_BUFFERS_buffers, SPA_POD_CHOICE_RANGE_Int(buffers, SPA_PARAM_BUFFERS_buffers, SPA_POD_CHOICE_RANGE_Int(2,
MIN_BUFFERS, MAX_BUFFERS), MIN_BUFFERS, MAX_BUFFERS),
SPA_PARAM_BUFFERS_blocks, SPA_POD_Int(blocks), SPA_PARAM_BUFFERS_blocks, SPA_POD_Int(blocks),
SPA_PARAM_BUFFERS_size, SPA_POD_CHOICE_RANGE_Int( SPA_PARAM_BUFFERS_size, SPA_POD_CHOICE_RANGE_Int(
size, size, maxsize), size,
16 * s->frame_size,
INT32_MAX),
SPA_PARAM_BUFFERS_stride, SPA_POD_Int(stride)); SPA_PARAM_BUFFERS_stride, SPA_POD_Int(stride));
return param; return param;
} }