mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

pulse-server: stream: only remove from list if pending

Browse source 
Only call `spa_list_remove()` in `stream_free()` if the
stream is pending. `spa_list_remove()` does not reinitialize
the list node, therefore calling `spa_list_remove()` again
after the stream has been removed from the pending list
will corrupt the pending list of the client.
This commit is contained in:
Barnabás Pőcze 2021-12-14 14:39:38 +01:00 • committed by Wim Taymans
parent 043934655a
commit 6f412236d5
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/modules/module-protocol-pulse/stream.c
View file

@ -96,7 +96,8 @@ void stream_free(struct stream *stream)
pw_log_debug("client %p: stream %p channel:%d", client, stream, stream->channel);
spa_list_remove(&stream->link);
if (stream->pending)
spa_list_remove(&stream->link);
if (stream->drain_tag)
reply_error(client, -1, stream->drain_tag, -ENOENT);