mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

acp: Check return value of asprintf

Browse source 
Building with `-D c_args="-D_FORTIFY_SOURCE=2"` triggers warnings:

    ../spa/plugins/alsa/acp/acp.c: In function ‘add_pro_profile’:
    ../spa/plugins/alsa/acp/acp.c:298:2: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
      298 |  asprintf(&device, "hw:%d", index);
          |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../spa/plugins/alsa/acp/acp.c:334:4: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
      334 |    asprintf(&name, "Mapping pro-output-%d", dev);
          |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    ../spa/plugins/alsa/acp/acp.c:364:4: warning: ignoring return value of ‘asprintf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
      364 |    asprintf(&name, "Mapping pro-input-%d", dev);
          |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commit is contained in:
Jan Alexander Steffens (heftig) 2021-03-13 15:35:38 +01:00 • committed by Wim Taymans
parent 9cdf3d1a0b
commit 6e2f78fffc
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
spa/plugins/alsa/acp/acp.c
View file

@ -295,7 +295,7 @@ static int add_pro_profile(pa_card *impl, uint32_t index)
ap->input_name = pa_xstrdup("pro-input");
ap->priority = 1;
asprintf(&device, "hw:%d", index);
pa_assert_se(asprintf(&device, "hw:%d", index) >= 0);
if ((err = snd_ctl_open(&ctl_hndl, device, 0)) < 0) {
pa_log_error("can't open control for card %s: %s",
@ -331,7 +331,7 @@ static int add_pro_profile(pa_card *impl, uint32_t index)
pa_log_error("error pcm info: %s", snd_strerror(err));
}
if (err >= 0) {
asprintf(&name, "Mapping pro-output-%d", dev);
pa_assert_se(asprintf(&name, "Mapping pro-output-%d", dev) >= 0);
m = pa_alsa_mapping_get(ps, name);
m->description = pa_xstrdup(desc);
m->device_strings = pa_split_spaces_strv(devstr);
@ -361,7 +361,7 @@ static int add_pro_profile(pa_card *impl, uint32_t index)
pa_log_error("error pcm info: %s", snd_strerror(err));
}
if (err >= 0) {
asprintf(&name, "Mapping pro-input-%d", dev);
pa_assert_se(asprintf(&name, "Mapping pro-input-%d", dev) >= 0);
m = pa_alsa_mapping_get(ps, name);
m->description = pa_xstrdup(desc);
m->device_strings = pa_split_spaces_strv(devstr);