mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-05-03 06:47:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

security: add missing NULL checks and fix error handling in modules

Browse source 
module-access: add NULL check after pw_properties_new for
socket_access.

module-pulse-tunnel: add NULL check after 4MB calloc for ring
buffer.

module-rt: add NULL check after calloc in thread create.

module-rtp-session: add goto error after failed
pw_net_parse_address instead of falling through.

module-snapcast-discover: fix missing null-termination on
network-received data before logging it as a string.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Wim Taymans 2026-04-30 18:38:32 +02:00
parent 47ca937905
commit 6cc92c0e2b
5 changed files with 14 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/modules/module-access.c
View file

@ -389,6 +389,10 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args_str)
pw_context_conf_update_props(context, "module."NAME".args", args);
impl->socket_access = pw_properties_new(NULL, NULL);
if (impl->socket_access == NULL) {
res = -errno;
goto error;
}
if ((res = parse_args(impl, props, args)) < 0)
goto error;

4
src/modules/module-pulse-tunnel.c
View file

@ -1149,6 +1149,10 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args)
spa_ringbuffer_init(&impl->ring);
impl->buffer = calloc(1, RINGBUFFER_SIZE);
if (impl->buffer == NULL) {
res = -errno;
goto error;
}
spa_dll_init(&impl->dll);
impl->rate_limit.interval = 2 * SPA_NSEC_PER_SEC;
impl->rate_limit.burst = 1;

2
src/modules/module-rt.c
View file

@ -741,6 +741,8 @@ static struct spa_thread *impl_create(void *object, const struct spa_dict *props
struct spa_thread *thread;
this = calloc(1, sizeof(*this));
if (this == NULL)
return NULL;
this->impl = impl;
this->start = start_routine;
this->arg = arg;

2
src/modules/module-rtp-session.c
View file

@ -1417,9 +1417,11 @@ static void on_zeroconf_added(void *data, const void *user, const struct spa_dic
if ((res = pw_net_parse_address(address, port, &sess->ctrl_addr, &sess->ctrl_len)) < 0) {
pw_log_error("invalid address %s: %s", address, spa_strerror(res));
goto error;
}
if ((res = pw_net_parse_address(address, port+1, &sess->data_addr, &sess->data_len)) < 0) {
pw_log_error("invalid address %s: %s", address, spa_strerror(res));
goto error;
}
return;
error:

3
src/modules/module-snapcast-discover.c
View file

@ -351,7 +351,7 @@ static int process_input(struct tunnel *t)
int res = 0;
while (true) {
res = read(t->source->fd, buffer, sizeof(buffer));
res = read(t->source->fd, buffer, sizeof(buffer) - 1);
if (res == 0)
return -EPIPE;
if (res < 0) {
@ -362,6 +362,7 @@ static int process_input(struct tunnel *t)
return res;
break;
}
buffer[res] = '\0';
}
pw_log_info("received: %s", buffer);