mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-31 22:25:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

gst: fix stream params memory leak

Browse source 
Both the GPtrArray and its contents are leaked in case of success.
`pw_stream_connect()` copies the params as needed, so use `g_autoptr()`
to free the array and with it, its contents.
This commit is contained in:
Barnabás Pőcze 2024-05-02 00:37:28 +02:00 • committed by Wim Taymans
parent 2d379bf908
commit 6c7dabb1e7
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/gst/gstpipewiresink.c
View file

@ -563,7 +563,7 @@ static gboolean
gst_pipewire_sink_setcaps (GstBaseSink * bsink, GstCaps * caps) gst_pipewire_sink_setcaps (GstBaseSink * bsink, GstCaps * caps)
{ {
GstPipeWireSink *pwsink; GstPipeWireSink *pwsink;
GPtrArray *possible; g_autoptr(GPtrArray) possible = NULL;
enum pw_stream_state state; enum pw_stream_state state;
const char *error = NULL; const char *error = NULL;
gboolean res = FALSE; gboolean res = FALSE;
@ -658,7 +658,6 @@ start_error:
{ {
GST_ERROR ("could not start stream: %s", error); GST_ERROR ("could not start stream: %s", error);
pw_thread_loop_unlock (pwsink->core->loop); pw_thread_loop_unlock (pwsink->core->loop);
g_ptr_array_unref (possible);
return FALSE; return FALSE;
} }
} }