From 6a689b3c7f2d284b8439eceaa8a782b391cc3412 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 20 May 2020 15:18:19 +0200 Subject: [PATCH] client-node: don't ref destroyed resource Ownership of the node_resource is taken by _new() and freed. Don't try to use it afterwards to send an error when something goes wrong but use the original resource. --- src/modules/module-client-node.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/modules/module-client-node.c b/src/modules/module-client-node.c index 6a993d684..a5b5f9c13 100644 --- a/src/modules/module-client-node.c +++ b/src/modules/module-client-node.c @@ -97,11 +97,8 @@ error_resource: goto error_exit; error_node: pw_log_error("can't create node: %s", spa_strerror(res)); - pw_resource_errorf(node_resource, res, "can't create node: %s", spa_strerror(res)); - goto error_exit_free; - -error_exit_free: - pw_resource_remove(node_resource); + pw_resource_errorf_id(resource, new_id, res, "can't create node: %s", spa_strerror(res)); + goto error_exit; error_exit: errno = -res; return NULL;