From 669fbf10c12822678a756184e1c734438905b584 Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Thu, 3 Jun 2021 12:53:05 +0200 Subject: [PATCH] fix some leaks in error paths --- .../module-protocol-pulse/modules/module-combine-sink.c | 4 ++-- src/modules/module-rt.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/module-protocol-pulse/modules/module-combine-sink.c b/src/modules/module-protocol-pulse/modules/module-combine-sink.c index 282cd8106..0e8b3aefb 100644 --- a/src/modules/module-protocol-pulse/modules/module-combine-sink.c +++ b/src/modules/module-protocol-pulse/modules/module-combine-sink.c @@ -402,7 +402,7 @@ struct module *create_module_combine_sink(struct impl *impl, const char *argumen struct module_combine_sink_data *d; struct pw_properties *props = NULL; const char *str; - char *sink_name, **sink_names = NULL; + char *sink_name = NULL, **sink_names = NULL; struct spa_audio_info_raw info = { 0 }; int i, n, res; @@ -461,8 +461,8 @@ struct module *create_module_combine_sink(struct impl *impl, const char *argumen return module; out: pw_properties_free(props); + free(sink_name); pw_free_strv(sink_names); errno = -res; - return NULL; } diff --git a/src/modules/module-rt.c b/src/modules/module-rt.c index 4cd9a83cf..5ff2a1c9b 100644 --- a/src/modules/module-rt.c +++ b/src/modules/module-rt.c @@ -243,7 +243,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args) return 0; error: + pw_properties_free(props); free(impl); - return res; }