mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-02 09:01:50 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-rtp: Allow overriding session version

Browse source 
This allows us to set an session version for the SAP externally. Also
the default is changed from 0 to an NTP timestamp, as recommended by the
spec[1].

[1] https://datatracker.ietf.org/doc/html/rfc4566#section-5.2
This commit is contained in:
Arun Raghavan 2024-07-05 10:42:53 -04:00 • committed by Wim Taymans
parent 7c8453f260
commit 6623eb8254
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/modules/module-rtp-sap.c
View file

@ -180,6 +180,7 @@ static const struct spa_dict_item module_info[] = {
struct sdp_info { struct sdp_info {
uint16_t hash; uint16_t hash;
uint32_t session_id; uint32_t session_id;
uint32_t session_version;
uint32_t t_ntp; uint32_t t_ntp;
char *origin; char *origin;
@ -687,12 +688,12 @@ static int send_sap(struct impl *impl, struct session *sess, bool bye)
the end. */ the end. */
spa_strbuf_append(&buf, spa_strbuf_append(&buf,
"v=0\n" "v=0\n"
"o=%s %u 0 IN %s %s\n" "o=%s %u %u IN %s %s\n"
"s=%s\n" "s=%s\n"
"c=IN %s %s%s\n" "c=IN %s %s%s\n"
"t=%u 0\n" "t=%u 0\n"
"m=%s %u RTP/AVP %i\n", "m=%s %u RTP/AVP %i\n",
user_name, sdp->session_id, src_ip4 ? "IP4" : "IP6", src_addr, user_name, sdp->session_id, sdp->session_version, src_ip4 ? "IP4" : "IP6", src_addr,
sdp->session_name, sdp->session_name,
dst_ip4 ? "IP4" : "IP6", dst_addr, dst_ttl, dst_ip4 ? "IP4" : "IP6", dst_addr, dst_ttl,
sdp->t_ntp, sdp->t_ntp,
@ -865,6 +866,14 @@ static struct session *session_new_announce(struct impl *impl, struct node *node
sdp->session_id = (uint32_t) time(NULL) + 2208988800U + impl->n_sessions; sdp->session_id = (uint32_t) time(NULL) + 2208988800U + impl->n_sessions;
sdp->t_ntp = pw_properties_get_uint32(props, "rtp.ntp", sdp->session_id); sdp->t_ntp = pw_properties_get_uint32(props, "rtp.ntp", sdp->session_id);
} }
if ((str = pw_properties_get(props, "sess.version")) != NULL) {
if (!spa_atou32(str, &sdp->session_version, 10)) {
pw_log_error("Invalid session version: %s (must be a uint32)", str);
goto error_free;
}
} else {
sdp->session_version = sdp->t_ntp;
}
sess->props = props; sess->props = props;
if ((str = pw_properties_get(props, "sess.name")) == NULL) if ((str = pw_properties_get(props, "sess.name")) == NULL)

1
src/modules/module-rtp-sink.c
View file

@ -530,6 +530,7 @@ int pipewire__module_init(struct pw_impl_module *module, const char *args)
copy_props(impl, props, "sess.media"); copy_props(impl, props, "sess.media");
copy_props(impl, props, "sess.name"); copy_props(impl, props, "sess.name");
copy_props(impl, props, "sess.id"); copy_props(impl, props, "sess.id");
copy_props(impl, props, "sess.version");
copy_props(impl, props, "sess.min-ptime"); copy_props(impl, props, "sess.min-ptime");
copy_props(impl, props, "sess.max-ptime"); copy_props(impl, props, "sess.max-ptime");
copy_props(impl, props, "sess.latency.msec"); copy_props(impl, props, "sess.latency.msec");