From 613c0a2558f70759f3fdc82ea4bda5236fe7b70e Mon Sep 17 00:00:00 2001 From: Wim Taymans Date: Wed, 9 Feb 2022 16:34:06 +0100 Subject: [PATCH] proxy: emit a warning when listener was not removed Emit a warning when the listener was not removed now that most places are fixed. Not removing a listener might fail to call the removed callback and leave things in a broken state. --- src/pipewire/proxy.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pipewire/proxy.c b/src/pipewire/proxy.c index bdcbb67cc..44d4b3f47 100644 --- a/src/pipewire/proxy.c +++ b/src/pipewire/proxy.c @@ -299,9 +299,11 @@ void pw_proxy_unref(struct pw_proxy *proxy) assert(proxy->destroyed); spa_list_for_each(h, &proxy->object_listener_list.list, link) - pw_log_debug("%p: leaked proxy object listener %p id:%d", proxy, h, proxy->id); + pw_log_warn("%p: proxy %u: leaked object listener %p", + proxy, proxy->id, h); spa_list_for_each(h, &proxy->listener_list.list, link) - pw_log_debug("%p: leaked proxy listener %p id:%d", proxy, h, proxy->id); + pw_log_warn("%p: proxy %u: leaked listener %p", + proxy, proxy->id, h); free(proxy); }