mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2026-04-29 06:46:38 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

module-rtp: handle the send_packet/feedback as callbacks

Browse source 
They are emited from the streaming thread and therefore can be emitted
concurrently with the events on the main thread. This can cause crashes
when the hook list is iterated.

Instead, make those events into callbacks that are more efficient,
and threadsafe.
This commit is contained in:
Wim Taymans 2026-03-26 09:34:45 +01:00
parent 50fcf64058
commit 60062432b8
4 changed files with 13 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/modules/module-rtp/midi.c
View file

@ -151,7 +151,7 @@ static int parse_journal(struct impl *impl, uint8_t *packet, uint16_t seq, uint3
return -EINVAL;
j = (struct rtp_midi_journal*)packet;
uint16_t seqnum = ntohs(j->checkpoint_seqnum);
rtp_stream_emit_send_feedback(impl, seqnum);
rtp_stream_call_send_feedback(impl, seqnum);
return 0;
}
@ -453,7 +453,7 @@ static void rtp_midi_flush_packets(struct impl *impl,
pw_log_trace("sending %d timestamp:%d %u %u",
len, timestamp + base,
offset, impl->psamples);
rtp_stream_emit_send_packet(impl, iov, 3);
rtp_stream_call_send_packet(impl, iov, 3);
impl->seq++;
len = 0;
@ -491,7 +491,7 @@ static void rtp_midi_flush_packets(struct impl *impl,
iov[2].iov_len = len;
pw_log_trace("sending %d timestamp:%d", len, base);
rtp_stream_emit_send_packet(impl, iov, 3);
rtp_stream_call_send_packet(impl, iov, 3);
impl->seq++;
}
}