mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-15 07:00:05 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

impl-node: remove old check

Browse source 
Remove the check for the target rate and duration. The drivers are
supposed to update that now.

The check is a little racy because a new target could have been
configured right after the driver emitted the ready signal. In that
case we should not update the clock values but let the driver run with
the old values and let the new values become active in the next cycle.
This commit is contained in:
Wim Taymans 2024-11-26 10:59:54 +01:00
parent e74e7b938e
commit 5e0e1204d7
1 changed files with 0 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/pipewire/impl-node.c
View file

@ -2105,20 +2105,6 @@ static int node_ready(void *data, int status)
} }
} }
/* This update is done too late, the driver should do this
* before calling the ready callback so that it can use the new target
* duration and rate to schedule the next update. We do this here to
* help drivers that don't support this yet */
if (SPA_UNLIKELY(cl->duration != cl->target_duration ||
cl->rate.denom != cl->target_rate.denom)) {
pw_log_warn("driver %s did not update duration/rate (%"PRIu64"/%"PRIu64" %u/%u)",
node->name,
cl->duration, cl->target_duration,
cl->rate.denom, cl->target_rate.denom);
cl->duration = cl->target_duration;
cl->rate = cl->target_rate;
}
sync_type = check_updates(node, &reposition_owner); sync_type = check_updates(node, &reposition_owner);
owner[0] = SPA_ATOMIC_LOAD(a->segment_owner[0]); owner[0] = SPA_ATOMIC_LOAD(a->segment_owner[0]);
owner[1] = SPA_ATOMIC_LOAD(a->segment_owner[1]); owner[1] = SPA_ATOMIC_LOAD(a->segment_owner[1]);