mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-06 13:30:01 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

free() can handle NULL just fine so skip the check

Browse source 
Fixes #117
This commit is contained in:
Wim Taymans 2018-12-19 17:47:25 +01:00
parent 5390079b4a
commit 5c6bd8e5c7
10 changed files with 46 additions and 87 deletions
Download patch file Download diff file Expand all files Collapse all files

1
src/modules/module-protocol-dbus.c
View file

@ -211,6 +211,7 @@ static void client_destroy(struct client *this)
if (this->sender) {
spa_list_remove(&this->link);
free(this->sender);
this->sender = NULL;
}
}

1
src/pipewire/factory.c
View file

@ -67,7 +67,6 @@ void pw_factory_destroy(struct pw_factory *factory)
spa_hook_remove(&factory->global_listener);
pw_global_destroy(factory->global);
}
if (factory->info.name)
free((char *)factory->info.name);
if (factory->properties)
pw_properties_free(factory->properties);

24
src/pipewire/introspect.c
View file

@ -130,22 +130,18 @@ struct pw_core_info *pw_core_info_update(struct pw_core_info *info,
info->change_mask = update->change_mask;
if (update->change_mask & PW_CORE_CHANGE_MASK_USER_NAME) {
if (info->user_name)
free((void *) info->user_name);
info->user_name = update->user_name ? strdup(update->user_name) : NULL;
}
if (update->change_mask & PW_CORE_CHANGE_MASK_HOST_NAME) {
if (info->host_name)
free((void *) info->host_name);
info->host_name = update->host_name ? strdup(update->host_name) : NULL;
}
if (update->change_mask & PW_CORE_CHANGE_MASK_VERSION) {
if (info->version)
free((void *) info->version);
info->version = update->version ? strdup(update->version) : NULL;
}
if (update->change_mask & PW_CORE_CHANGE_MASK_NAME) {
if (info->name)
free((void *) info->name);
info->name = update->name ? strdup(update->name) : NULL;
}
@ -161,13 +157,9 @@ struct pw_core_info *pw_core_info_update(struct pw_core_info *info,
void pw_core_info_free(struct pw_core_info *info)
{
if (info->user_name)
free((void *) info->user_name);
if (info->host_name)
free((void *) info->host_name);
if (info->version)
free((void *) info->version);
if (info->name)
free((void *) info->name);
if (info->props)
pw_spa_dict_destroy(info->props);
@ -190,7 +182,6 @@ struct pw_node_info *pw_node_info_update(struct pw_node_info *info,
info->change_mask = update->change_mask;
if (update->change_mask & PW_NODE_CHANGE_MASK_NAME) {
if (info->name)
free((void *) info->name);
info->name = update->name ? strdup(update->name) : NULL;
}
@ -205,7 +196,6 @@ struct pw_node_info *pw_node_info_update(struct pw_node_info *info,
if (update->change_mask & PW_NODE_CHANGE_MASK_STATE) {
info->state = update->state;
if (info->error)
free((void *) info->error);
info->error = update->error ? strdup(update->error) : NULL;
}
@ -220,9 +210,7 @@ struct pw_node_info *pw_node_info_update(struct pw_node_info *info,
void pw_node_info_free(struct pw_node_info *info)
{
if (info->name)
free((void *) info->name);
if (info->error)
free((void *) info->error);
if (info->props)
pw_spa_dict_destroy(info->props);
@ -245,7 +233,6 @@ struct pw_port_info *pw_port_info_update(struct pw_port_info *info,
info->change_mask = update->change_mask;
if (update->change_mask & PW_PORT_CHANGE_MASK_NAME) {
if (info->name)
free((void *) info->name);
info->name = update->name ? strdup(update->name) : NULL;
}
@ -260,7 +247,6 @@ struct pw_port_info *pw_port_info_update(struct pw_port_info *info,
void pw_port_info_free(struct pw_port_info *info)
{
if (info->name)
free((void *) info->name);
if (info->props)
pw_spa_dict_destroy(info->props);
@ -279,7 +265,6 @@ struct pw_factory_info *pw_factory_info_update(struct pw_factory_info *info,
return NULL;
}
info->id = update->id;
if (info->name)
free((void *) info->name);
info->name = update->name ? strdup(update->name) : NULL;
info->type = update->type;
@ -296,7 +281,6 @@ struct pw_factory_info *pw_factory_info_update(struct pw_factory_info *info,
void pw_factory_info_free(struct pw_factory_info *info)
{
if (info->name)
free((void *) info->name);
if (info->props)
pw_spa_dict_destroy(info->props);
@ -318,17 +302,14 @@ struct pw_module_info *pw_module_info_update(struct pw_module_info *info,
info->change_mask = update->change_mask;
if (update->change_mask & PW_MODULE_CHANGE_MASK_NAME) {
if (info->name)
free((void *) info->name);
info->name = update->name ? strdup(update->name) : NULL;
}
if (update->change_mask & PW_MODULE_CHANGE_MASK_FILENAME) {
if (info->filename)
free((void *) info->filename);
info->filename = update->filename ? strdup(update->filename) : NULL;
}
if (update->change_mask & PW_MODULE_CHANGE_MASK_ARGS) {
if (info->args)
free((void *) info->args);
info->args = update->args ? strdup(update->args) : NULL;
}
@ -342,11 +323,8 @@ struct pw_module_info *pw_module_info_update(struct pw_module_info *info,
void pw_module_info_free(struct pw_module_info *info)
{
if (info->name)
free((void *) info->name);
if (info->filename)
free((void *) info->filename);
if (info->args)
free((void *) info->args);
if (info->props)
pw_spa_dict_destroy(info->props);
@ -406,7 +384,6 @@ struct pw_link_info *pw_link_info_update(struct pw_link_info *info,
info->input_port_id = update->input_port_id;
}
if (update->change_mask & PW_LINK_CHANGE_MASK_FORMAT) {
if (info->format)
free(info->format);
info->format = pw_spa_pod_copy(update->format);
}
@ -415,7 +392,6 @@ struct pw_link_info *pw_link_info_update(struct pw_link_info *info,
void pw_link_info_free(struct pw_link_info *info)
{
if (info->format)
free(info->format);
free(info);
}

5
src/pipewire/link.c
View file

@ -215,8 +215,6 @@ static int do_negotiate(struct pw_link *this, uint32_t in_state, uint32_t out_st
pw_work_queue_add(impl->work, input->node, res2, complete_ready, input);
}
if (this->info.format)
free(this->info.format);
this->info.format = format;
@ -235,7 +233,6 @@ static int do_negotiate(struct pw_link *this, uint32_t in_state, uint32_t out_st
error:
pw_link_update_state(this, PW_LINK_STATE_ERROR, error);
if (format)
free(format);
return res;
}
@ -1311,9 +1308,7 @@ void pw_link_destroy(struct pw_link *link)
if (link->properties)
pw_properties_free(link->properties);
if (link->info.format)
free(link->info.format);
free(impl);
}

3
src/pipewire/module.c
View file

@ -299,11 +299,8 @@ void pw_module_destroy(struct pw_module *module)
spa_list_for_each_safe(resource, tmp, &module->resource_list, link)
pw_resource_destroy(resource);
if (module->info.name)
free((char *) module->info.name);
if (module->info.filename)
free((char *) module->info.filename);
if (module->info.args)
free((char *) module->info.args);
dlclose(impl->hnd);

2
src/pipewire/node.c
View file

@ -654,7 +654,6 @@ void pw_node_destroy(struct pw_node *node)
pw_map_clear(&node->input_port_map);
pw_map_clear(&node->output_port_map);
if (node->properties)
pw_properties_free(node->properties);
clear_info(node);
@ -922,7 +921,6 @@ void pw_node_update_state(struct pw_node *node, enum pw_node_state state, char *
pw_log_debug("node %p: update state from %s -> %s", node,
pw_node_state_as_string(old), pw_node_state_as_string(state));
if (node->info.error)
free((char*)node->info.error);
node->info.error = error;
node->info.state = state;

1
src/pipewire/port.c
View file

@ -564,7 +564,6 @@ void pw_port_destroy(struct pw_port *port)
pw_map_clear(&port->mix_port_map);
if (port->properties)
pw_properties_free(port->properties);
free(port);

6
src/pipewire/remote.c
View file

@ -124,7 +124,6 @@ pw_remote_update_state(struct pw_remote *remote, enum pw_remote_state state, con
enum pw_remote_state old = remote->state;
if (old != state) {
if (remote->error)
free(remote->error);
if (fmt) {
@ -305,8 +304,9 @@ void pw_remote_destroy(struct pw_remote *remote)
spa_list_remove(&remote->link);
if (remote->properties)
pw_log_debug("remote %p: free", remote);
pw_properties_free(remote->properties);
free(remote->error);
free(impl);
}
@ -452,7 +452,7 @@ int pw_remote_disconnect(struct pw_remote *remote)
remote->n_types = 0;
if (remote->info) {
pw_core_info_free (remote->info);
pw_core_info_free(remote->info);
remote->info = NULL;
}
pw_remote_update_state(remote, PW_REMOTE_STATE_UNCONNECTED, NULL);

6
src/pipewire/stream.c
View file

@ -304,7 +304,6 @@ static bool stream_set_state(struct pw_stream *stream, enum pw_stream_state stat
enum pw_stream_state old = stream->state;
bool res = old != state;
if (res) {
if (stream->error)
free(stream->error);
stream->error = error;
@ -540,13 +539,9 @@ void pw_stream_destroy(struct pw_stream *stream)
pw_array_clear(&impl->mem_ids);
if (stream->error)
free(stream->error);
if (stream->name)
free(stream->name);
if (stream->properties)
pw_properties_free(stream->properties);
free(impl);
@ -948,7 +943,6 @@ client_node_port_set_param(void *data,
pw_log_debug("stream %p: format changed %d", stream, seq);
if (impl->format)
free(impl->format);
if (spa_pod_is_object_type(param, t->spa_format)) {