mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-10-29 05:40:27 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

bluez5: media-source: don't set node.latency by default

Browse source 
The hardcoded latency of 512/<rate> is quite low on some ALSA devices.
Instead of forcing that latency onto the graph, just don't set it at all
unless it originates from the BAP presentation delay. That means that
the functionality remains the same for BAP but changes for A2DP to favor
the preferred quantum of the ALSA sink (or whatever is the driver).

Also, avoid setting an empty string ("") latency and rate in the cases
where it's not defined. This allows users to override those properties
through the wireplumber monitor rules if they need to.
This commit is contained in:
George Kiagiadakis 2025-08-23 22:47:34 +03:00 • committed by Wim Taymans
parent 3b33f60d2f
commit 5af8340183
1 changed files with 13 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
spa/plugins/bluez5/media-source.c
View file

@ -1135,15 +1135,23 @@ static void emit_node_info(struct impl *this, bool full)
{ SPA_KEY_DEVICE_API, "bluez5" },
{ SPA_KEY_MEDIA_CLASS, this->is_internal ? "Audio/Source/Internal" :
this->is_input ? "Audio/Source" : "Stream/Output/Audio" },
{ SPA_KEY_NODE_LATENCY, this->is_input ? "" : latency },
{ "media.name", media_name },
{ "node.rate", this->is_input ? "" : rate },
{ SPA_KEY_NODE_DRIVER, this->is_input ? "true" : "false" },
{ SPA_KEY_MEDIA_ROLE, media_role },
/* reserved for latency and rate; see below */
{ NULL, NULL },
{ NULL, NULL }
};
spa_scnprintf(latency, sizeof(latency), "%u/%u", this->node_latency, port->current_format.info.raw.rate);
spa_scnprintf(rate, sizeof(rate), "1/%u", port->current_format.info.raw.rate);
if (!this->is_input && this->node_latency != 0) {
node_info_items[SPA_N_ELEMENTS(node_info_items) - 2].key = SPA_KEY_NODE_LATENCY;
node_info_items[SPA_N_ELEMENTS(node_info_items) - 2].value = latency;
node_info_items[SPA_N_ELEMENTS(node_info_items) - 1].key = "node.rate";
node_info_items[SPA_N_ELEMENTS(node_info_items) - 1].value = rate;
spa_scnprintf(latency, sizeof(latency), "%u/%u", this->node_latency, port->current_format.info.raw.rate);
spa_scnprintf(rate, sizeof(rate), "1/%u", port->current_format.info.raw.rate);
}
if (full)
this->info.change_mask = this->info_all;
@ -2074,7 +2082,7 @@ impl_init(const struct spa_handle_factory *factory,
this->timerfd = spa_system_timerfd_create(this->data_system,
CLOCK_MONOTONIC, SPA_FD_CLOEXEC | SPA_FD_NONBLOCK);
this->node_latency = 512;
this->node_latency = 0;
set_latency(this, false);