mirror of
				https://gitlab.freedesktop.org/pipewire/pipewire.git
				synced 2025-11-03 09:01:54 -05:00 
			
		
		
		
	pulse-server: do not put static properties into module::props
				
					
				
			Now that the module's properties are served from `module_info::properties`, there is no need for modules to put their static properties into the `module::props` dictionary.
This commit is contained in:
		
							parent
							
								
									c9f632da9f
								
							
						
					
					
						commit
						5ad52bb88a
					
				
					 23 changed files with 23 additions and 23 deletions
				
			
		| 
						 | 
				
			
			@ -109,7 +109,7 @@ struct module *create_module_always_sink(struct impl *impl, const char *argument
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_always_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -512,7 +512,7 @@ struct module *create_module_combine_sink(struct impl *impl, const char *argumen
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_combine_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -166,7 +166,7 @@ struct module *create_module_echo_cancel(struct impl *impl, const char *argument
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_echo_cancel_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	aec_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	source_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	sink_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -189,7 +189,7 @@ struct module *create_module_ladspa_sink(struct impl *impl, const char *argument
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_ladspa_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props || !playback_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -189,7 +189,7 @@ struct module *create_module_ladspa_source(struct impl *impl, const char *argume
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_ladspa_source_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props || !playback_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -154,7 +154,7 @@ struct module *create_module_loopback(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_loopback_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props || !playback_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -92,7 +92,7 @@ struct module *create_module_native_protocol_tcp(struct impl *impl, const char *
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_native_protocol_tcp_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -169,7 +169,7 @@ struct module *create_module_null_sink(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_null_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -233,7 +233,7 @@ struct module *create_module_pipe_sink(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_pipe_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -253,7 +253,7 @@ struct module *create_module_pipe_source(struct impl *impl, const char *argument
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_pipe_source_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !playback_props) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -101,7 +101,7 @@ struct module *create_module_raop_discover(struct impl *impl, const char *argume
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_raop_discover_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -155,7 +155,7 @@ struct module *create_module_remap_sink(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_remap_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props || !playback_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -155,7 +155,7 @@ struct module *create_module_remap_source(struct impl *impl, const char *argumen
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_remap_source_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	capture_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	playback_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !capture_props || !playback_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -134,7 +134,7 @@ struct module *create_module_roc_sink_input(struct impl *impl, const char *argum
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_roc_sink_input_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	source_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	roc_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !source_props || !roc_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -133,7 +133,7 @@ struct module *create_module_roc_sink(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_roc_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	sink_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	roc_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !sink_props || !roc_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -134,7 +134,7 @@ struct module *create_module_roc_source(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_roc_source_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	source_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	roc_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props || !source_props || !roc_props) {
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -141,7 +141,7 @@ struct module *create_module_simple_protocol_tcp(struct impl *impl, const char *
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_simple_protocol_tcp_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -257,7 +257,7 @@ struct module *create_module_switch_on_connect(struct impl *impl, const char *ar
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_switch_on_connect_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -160,7 +160,7 @@ struct module *create_module_tunnel_sink(struct impl *impl, const char *argument
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_tunnel_sink_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	stream_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL || stream_props == NULL) {
 | 
			
		||||
		res = -ENOMEM;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -160,7 +160,7 @@ struct module *create_module_tunnel_source(struct impl *impl, const char *argume
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_tunnel_source_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	stream_props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL || stream_props == NULL) {
 | 
			
		||||
		res = -ENOMEM;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -119,7 +119,7 @@ struct module *create_module_x11_bell(struct impl *impl, const char *argument)
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_x11_bell_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -EINVAL;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -101,7 +101,7 @@ struct module *create_module_zeroconf_discover(struct impl *impl, const char *ar
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_zeroconf_discover_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (props == NULL) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
| 
						 | 
				
			
			@ -656,7 +656,7 @@ struct module *create_module_zeroconf_publish(struct impl *impl, const char *arg
 | 
			
		|||
 | 
			
		||||
	PW_LOG_TOPIC_INIT(mod_topic);
 | 
			
		||||
 | 
			
		||||
	props = pw_properties_new_dict(&SPA_DICT_INIT_ARRAY(module_zeroconf_publish_info));
 | 
			
		||||
	props = pw_properties_new(NULL, NULL);
 | 
			
		||||
	if (!props) {
 | 
			
		||||
		res = -errno;
 | 
			
		||||
		goto out;
 | 
			
		||||
| 
						 | 
				
			
			
 | 
			
		|||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue