mirrors/pipewire
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/pipewire/pipewire.git synced 2025-11-03 09:01:54 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

libcamera: Fix 90/270 degree transforms

Browse source 
`Transform::Rot90` means the client should rotate 90 deg. clockwise,
which matches `SPA_META_TRANSFORMATION_90`, i.e. the buffer was
rotated 90 deg. anti-clockwise. The flipped cases should be correct
though.

Also add the source value to the debug print for easier future
debugging.

Fixes fa799aac86
This commit is contained in:
Robert Mader 2022-12-07 12:19:01 +01:00
parent cf3d4c3b5d
commit 59d393bd30
1 changed files with 5 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
spa/plugins/libcamera/libcamera-utils.cpp
View file

@ -709,8 +709,8 @@ static const struct {
{ Transform::HVFlip, SPA_META_TRANSFORMATION_180 }, { Transform::HVFlip, SPA_META_TRANSFORMATION_180 },
{ Transform::Rot180, SPA_META_TRANSFORMATION_180 }, { Transform::Rot180, SPA_META_TRANSFORMATION_180 },
{ Transform::Transpose, SPA_META_TRANSFORMATION_Flipped90 }, { Transform::Transpose, SPA_META_TRANSFORMATION_Flipped90 },
{ Transform::Rot90, SPA_META_TRANSFORMATION_270 }, { Transform::Rot90, SPA_META_TRANSFORMATION_90 },
{ Transform::Rot270, SPA_META_TRANSFORMATION_90 }, { Transform::Rot270, SPA_META_TRANSFORMATION_270 },
{ Transform::Rot180Transpose, SPA_META_TRANSFORMATION_Flipped270 }, { Transform::Rot180Transpose, SPA_META_TRANSFORMATION_Flipped270 },
}; };
@ -772,8 +772,9 @@ mmap_init(struct impl *impl, struct port *port,
if (b->videotransform) { if (b->videotransform) {
b->videotransform->transform = b->videotransform->transform =
libcamera_transform_to_spa_transform_value(impl->config->transform); libcamera_transform_to_spa_transform_value(impl->config->transform);
spa_log_debug(impl->log, "Setting videotransform for buffer %d to %u", spa_log_debug(impl->log, "Setting videotransform for buffer %d to %u (from %s)",
i, b->videotransform->transform); i, b->videotransform->transform, transformToString(impl->config->transform));
} }
d = buffers[i]->datas; d = buffers[i]->datas;